Skip to content

qt: Use window() instead of obsolete topLevelWidget() #14801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Dec 9, 2018
Merged

qt: Use window() instead of obsolete topLevelWidget() #14801

laanwj merged 1 commit into from
Dec 9, 2018

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Nov 25, 2018

@fanquake fanquake added the GUI label Nov 25, 2018
@practicalswift
Copy link
Contributor

practicalswift commented Nov 25, 2018

Concept ACK

@fanquake
Copy link
Member

fanquake commented Nov 26, 2018

utACK 0b4a578

Looking at qwidget.h in depends (5.9.6):

QWidget *window() const;
QWidget *nativeParentWidget() const;
inline QWidget *topLevelWidget() const { return window(); }

Also checked that there are no more usages of topLevelWidget in the code base.

@maflcko maflcko added this to the 0.18.0 milestone Nov 26, 2018
@promag
Copy link
Contributor

promag commented Nov 27, 2018

ACK 0b4a578.

@ken2812221
Copy link
Contributor

ken2812221 commented Nov 30, 2018

tACK 0b4a578

@laanwj laanwj merged commit 0b4a578 into bitcoin:master Dec 9, 2018
laanwj added a commit that referenced this pull request Dec 9, 2018
@laanwj
Merge #14801: qt: Use window() instead of obsolete topLevelWidget()
0eb65aa 
0b4a578 Use window() instead of obsolete topLevelWidget() (Hennadii Stepanov)

Pull request description:

  `QWidget::topLevelWidget()` is obsolete since at least Qt 4.8.

  Refs:
  - https://doc-snapshots.qt.io/4.8/qwidget-obsolete.html#topLevelWidget
  - https://doc.qt.io/qt-5.9/qwidget-obsolete.html#topLevelWidget

Tree-SHA512: 45a79a3f11acd24bbf335603e60cb46545f4c9ce9b16280117676797a611c4422525abd39ad6784a7bc459926e3f5120b49a170403ff60ba4788d679862e3ff0
@hebasto hebasto deleted the 20181125-obsolete-toplevelwidget branch December 9, 2018 15:59
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Sep 30, 2020
@hebasto @PiRK
Use window() instead of obsolete topLevelWidget()
f898535 
Summary:
`topLevelWidget()` has been deprecated since Qt4.8, and returns `window()`

Backport of Core [[bitcoin/bitcoin#14801 | PR14801]]

Test Plan: `ninja ckeck-bitcoin-qt`

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7679
@furszy furszy mentioned this pull request May 11, 2021
Merged
TheArbitrator pushed a commit to TheArbitrator/dash that referenced this pull request Jun 23, 2021
@laanwj @HariQuick
Merge bitcoin#14801: qt: Use window() instead of obsolete topLevelWid…
504f157 
…get()

0b4a578 Use window() instead of obsolete topLevelWidget() (Hennadii Stepanov)

Pull request description:

  `QWidget::topLevelWidget()` is obsolete since at least Qt 4.8.

  Refs:
  - https://doc-snapshots.qt.io/4.8/qwidget-obsolete.html#topLevelWidget
  - https://doc.qt.io/qt-5.9/qwidget-obsolete.html#topLevelWidget

Tree-SHA512: 45a79a3f11acd24bbf335603e60cb46545f4c9ce9b16280117676797a611c4422525abd39ad6784a7bc459926e3f5120b49a170403ff60ba4788d679862e3ff0
barton2526 added a commit to barton2526/Gridcoin-Research that referenced this pull request Jun 23, 2021
@barton2526
qt: Use window() instead of obsolete topLevelWidget()
9522d7b 
Ref: bitcoin/bitcoin#14801
@barton2526 barton2526 mentioned this pull request Jun 24, 2021
Merged
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#14801: qt: Use window() instead of obsolete topLevelWid…
88f6133 
…get()

0b4a578 Use window() instead of obsolete topLevelWidget() (Hennadii Stepanov)

Pull request description:

  `QWidget::topLevelWidget()` is obsolete since at least Qt 4.8.

  Refs:
  - https://doc-snapshots.qt.io/4.8/qwidget-obsolete.html#topLevelWidget
  - https://doc.qt.io/qt-5.9/qwidget-obsolete.html#topLevelWidget

Tree-SHA512: 45a79a3f11acd24bbf335603e60cb46545f4c9ce9b16280117676797a611c4422525abd39ad6784a7bc459926e3f5120b49a170403ff60ba4788d679862e3ff0
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Jul 5, 2021
@laanwj @UdjinM6
Merge bitcoin#14801: qt: Use window() instead of obsolete topLevelWid…
31e35c8 
…get()

0b4a578 Use window() instead of obsolete topLevelWidget() (Hennadii Stepanov)

Pull request description:

  `QWidget::topLevelWidget()` is obsolete since at least Qt 4.8.

  Refs:
  - https://doc-snapshots.qt.io/4.8/qwidget-obsolete.html#topLevelWidget
  - https://doc.qt.io/qt-5.9/qwidget-obsolete.html#topLevelWidget

Tree-SHA512: 45a79a3f11acd24bbf335603e60cb46545f4c9ce9b16280117676797a611c4422525abd39ad6784a7bc459926e3f5120b49a170403ff60ba4788d679862e3ff0
furszy added a commit to PIVX-Project/PIVX that referenced this pull request Jul 6, 2021
@furszy
Merge #2380: [Cleanup] guiutils cleanup + fix memory mismanagement
92bea40 
2896a48 GUI: remove macOS start on login (furszy)
300d752 scripted-diff: prefer MAC_OSX over __APPLE__ (furszy)
7467c9f gui: remove macOS ProgressBar workaround (fanquake)
c7575ac gui: remove SubstituteFonts (fanquake)
15ed388 Use window() instead of obsolete topLevelWidget() (Hennadii Stepanov)
d6e1383 Fix macOS launch-at-startup memory issue (Jonas Schnelli)
233b156 Qt: remove macOS launch-at-startup option when compiled with > macOS 10.11 (Jonas Schnelli)
d787b25 Cleanup: Remove unused TableViewLastColumnResizingFixer and DHMSTableWidgetItem from guiutil.h/cpp (furszy)

Pull request description:

  Straightforward update for the `guiutil` files.
  First commit removes unused `TableViewLastColumnResizingFixer` and `DHMSTableWidgetItem` from `guiutil.h/cpp`.
  Second and third commit comes from bitcoin#15208.
  Fourth commit comes from bitcoin#14801.

ACKs for top commit:
  random-zebra:
    re-utACK 2896a48
  Fuzzbawls:
    utACK 2896a48

Tree-SHA512: b66920006007017a7fc9de06405627ab968d0d5fb2aab97d7131af6b044b34bbf370ebc47b87e3d088a83a1596d056b02e41d929e5180902ed6da4529e179f6d
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 8, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#14801: qt: Use window() instead of obsolete topLevelWid…
221ff42 
…get()

0b4a578 Use window() instead of obsolete topLevelWidget() (Hennadii Stepanov)

Pull request description:

  `QWidget::topLevelWidget()` is obsolete since at least Qt 4.8.

  Refs:
  - https://doc-snapshots.qt.io/4.8/qwidget-obsolete.html#topLevelWidget
  - https://doc.qt.io/qt-5.9/qwidget-obsolete.html#topLevelWidget

Tree-SHA512: 45a79a3f11acd24bbf335603e60cb46545f4c9ce9b16280117676797a611c4422525abd39ad6784a7bc459926e3f5120b49a170403ff60ba4788d679862e3ff0
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

GUI Refactoring

Projects

None yet

Milestone

0.18.0

Development

Successfully merging this pull request may close these issues.

7 participants

@hebasto @practicalswift @fanquake @promag @ken2812221 @laanwj @maflcko