Skip to content

Conversation

@practicalswift
Copy link
Contributor

Add ASan Travis build.

@fanquake fanquake added the Tests label Nov 23, 2018
@sipa
Copy link
Member

sipa commented Nov 24, 2018

Any reason to not enable ASan and UBSan in the same test?

@practicalswift practicalswift force-pushed the asan-in-travis branch 3 times, most recently from 7fdb0a7 to 7e5e3fa Compare November 25, 2018 22:03
@practicalswift practicalswift force-pushed the asan-in-travis branch 7 times, most recently from 64b8928 to 0a88263 Compare November 26, 2018 11:10
@practicalswift practicalswift changed the title [wip] Add ASan Travis build Add ASan Travis build Nov 26, 2018
@practicalswift
Copy link
Contributor Author

@sipa I was afraid the combined runtime would be too long, but it appears to work. The two Travis jobs have now been merged. Please review.

@MarcoFalke Now running also with LSan (LeakSanitizer). Please review :-)

@maflcko
Copy link
Member

maflcko commented Nov 26, 2018

Could squash everything except the changes in test/functional?

@practicalswift practicalswift changed the title Add ASan Travis build Add AddressSanitizer (ASan) Travis build Nov 26, 2018
@practicalswift
Copy link
Contributor Author

@MarcoFalke Done! Please re-review :-)

@maflcko maflcko changed the title Add AddressSanitizer (ASan) Travis build tests: Add AddressSanitizer (ASan) Travis build Nov 26, 2018
@practicalswift
Copy link
Contributor Author

@MarcoFalke Added comments as suggested. Please re-review :-)

@practicalswift practicalswift force-pushed the asan-in-travis branch 2 times, most recently from 78a62b6 to 65b019a Compare November 26, 2018 22:31
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request May 23, 2022
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
kwvg added a commit to kwvg/dash that referenced this pull request Jul 1, 2022
UdjinM6 added a commit to dashpay/dash that referenced this pull request Jul 2, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants