revert removal of fstream.hpp header in fs.h #14768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for some architectures.
Contributor
|
utACK |
Contributor
|
utACK e816b34 |
Contributor
|
utACK e816b34 |
Member
|
how did this get missed on review/testing? |
Member
|
Part of the problem is that apparantly Travis was down, and that wasn't noticed: #14763 (comment) |
Member
laanwj
added a commit
that referenced
this pull request
Nov 20, 2018
e816b34 revert removal of fstream.hpp header in fs.h (Karl-Johan Alm) Pull request description: We cannot (yet) remove the EXPECTED_BOOST_INCLUDES entry as this header is still needed in `fs.h` (see #14763). Partially reverts #14718. Tree-SHA512: e94d8d6208bee14af20a7a529e60a4898358ec8c070a8bf0701e589a2ae33df1305deac83cee619f103c24be0eb3c12a2f490209c125b247acf21561c7de456e
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Mar 20, 2020
Summary: c54e5a41c4 Remove unreferenced boost headers (Murray Nesbitt) Pull request description: Building with clang (e.g. on FreeBSD) is very noisy due to `-Wthread-safety-analysis` warnings regarding boost. This change removes a number of unnecessary boost includes, and silences the rest of the warnings when building with clang. This allows more potentially interesting warnings to surface from the noise. Tested on FreeBSD 11.2 Tree-SHA512: 5e6a0623188b9be59aeae52866799aefb4c3c9ab5e569b07ee8d43fc92e0b5f1f76b96bb54c35c7043148df84641b4a96927fb71f6eb00460c20cd19cf250900 Backport of Core [[bitcoin/bitcoin#14718 | PR14718]] and [[bitcoin/bitcoin#14768 | PR14768]] (reverts fs.h changes) Changes to util/system.cpp were ignored because we diverged here: https://reviews.bitcoinabc.org/rSTAGING47162673c79c757a9c038c4ddc41fb3022223bde Test Plan: ninja ninja check Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5523
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
May 19, 2020
Summary: c54e5a41c4 Remove unreferenced boost headers (Murray Nesbitt) Pull request description: Building with clang (e.g. on FreeBSD) is very noisy due to `-Wthread-safety-analysis` warnings regarding boost. This change removes a number of unnecessary boost includes, and silences the rest of the warnings when building with clang. This allows more potentially interesting warnings to surface from the noise. Tested on FreeBSD 11.2 Tree-SHA512: 5e6a0623188b9be59aeae52866799aefb4c3c9ab5e569b07ee8d43fc92e0b5f1f76b96bb54c35c7043148df84641b4a96927fb71f6eb00460c20cd19cf250900 Backport of Core [[bitcoin/bitcoin#14718 | PR14718]] and [[bitcoin/bitcoin#14768 | PR14768]] (reverts fs.h changes) Changes to util/system.cpp were ignored because we diverged here: https://reviews.bitcoinabc.org/rSTAGING47162673c79c757a9c038c4ddc41fb3022223bde Test Plan: ninja ninja check Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5523
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Aug 11, 2021
e816b34 revert removal of fstream.hpp header in fs.h (Karl-Johan Alm) Pull request description: We cannot (yet) remove the EXPECTED_BOOST_INCLUDES entry as this header is still needed in `fs.h` (see bitcoin#14763). Partially reverts bitcoin#14718. Tree-SHA512: e94d8d6208bee14af20a7a529e60a4898358ec8c070a8bf0701e589a2ae33df1305deac83cee619f103c24be0eb3c12a2f490209c125b247acf21561c7de456e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot (yet) remove the EXPECTED_BOOST_INCLUDES entry as this header is still needed in
fs.h(see #14763).Partially reverts #14718.