rpc: Correctly name arguments #14720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @ch4ot1c |
maflcko
force-pushed
the
Mf1811-rpcNameArguments
branch
from
5385e4e to
fad8314
Compare
maflcko
force-pushed
the
Mf1811-rpcNameArguments
branch
from
fad8314 to
fa0815c
Compare
Contributor
|
utACK fa0815c |
Contributor
|
Concept ACK Nice cleanup! |
Member
|
Makes sense, though I guess the idea eventually would be to use the just-merged
Might make sense to split them out to a commit that goes in before the |
Member
Author
|
By splitting it up, the changes are easier to potentially backport and also make review easier when we switch to |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
ryanofsky
approved these changes
Nov 13, 2018
maflcko
pushed a commit
that referenced
this pull request
Nov 13, 2018
fa0815c rpc: Correctly name arguments (Jon Layton) Pull request description: Consistently use the same name to describe arguments in the documentation and add a test that uses the name. By splitting it up, the changes are easier to potentially backport and also make review easier when we switch to `RPCHelpMan`. The tests should pass with or without the changes in `src`. Partly stolen from #14459 (More RPC help description fixes by ch4ot1c) Tree-SHA512: 1072992b1e93ac41006613523e54a0a8004f529fcb101eb9d74d91474abb0945a5a7539f249905151b904b87448f9efc0cacbd9e052fbe2ea9111e62f3e7249c
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 13, 2020
Summary: fa0815c300 rpc: Correctly name arguments (Jon Layton) Pull request description: Consistently use the same name to describe arguments in the documentation and add a test that uses the name. By splitting it up, the changes are easier to potentially backport and also make review easier when we switch to `RPCHelpMan`. The tests should pass with or without the changes in `src`. Partly stolen from #14459 (More RPC help description fixes by ch4ot1c) Tree-SHA512: 1072992b1e93ac41006613523e54a0a8004f529fcb101eb9d74d91474abb0945a5a7539f249905151b904b87448f9efc0cacbd9e052fbe2ea9111e62f3e7249c Backport of Core [[bitcoin/bitcoin#14720 | PR14720]] bitcoin/bitcoin#14720 Test Plan: ninja check ninja check-functional ./bitcoind ./bitcoin-cli help waitforblockheight ./bitcoin-cli help getblockheader ./bitcoin-cli help pruneblockchain ./bitcoin-cli help getchaintxstats ./bitcoin-cli help scantxoutset ./bitcoin-cli help prioritisetransaction ./bitcoin-cli help getblocktemplate ./bitcoin-cli help addnode ./bitcoin-cli help disconnectnode ./bitcoin-cli help setban ./bitcoin-cli help setnetworkactive ./bitcoin-cli help uptime ./bitcoin-cli help importprunedfunds ./bitcoin-cli help importmulti ./bitcoin-cli help getbalance ./bitcoin-cli help listtransactions Verify help text ./bitcoin-cli uptime <anything> Verify this fails with error code -1 and then displays the help message. Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D5281
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Aug 11, 2021
fa0815c rpc: Correctly name arguments (Jon Layton) Pull request description: Consistently use the same name to describe arguments in the documentation and add a test that uses the name. By splitting it up, the changes are easier to potentially backport and also make review easier when we switch to `RPCHelpMan`. The tests should pass with or without the changes in `src`. Partly stolen from bitcoin#14459 (More RPC help description fixes by ch4ot1c) Tree-SHA512: 1072992b1e93ac41006613523e54a0a8004f529fcb101eb9d74d91474abb0945a5a7539f249905151b904b87448f9efc0cacbd9e052fbe2ea9111e62f3e7249c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistently use the same name to describe arguments in the documentation and add a test that uses the name.
By splitting it up, the changes are easier to potentially backport and also make review easier when we switch to
RPCHelpMan.The tests should pass with or without the changes in
src.Partly stolen from #14459 (More RPC help description fixes by ch4ot1c)