build: Fix windows build error if --disable-bip70
#14686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
Contributor
|
Gitian builds for commit 11e1ac3 (master):
Gitian builds for commit 67a71c284fea254928fe0ec5d59a39c3d2765a7d (master and this pull):
|
Member
|
Going to merge this, since it has a tested ack in the linked issue. |
maflcko
pushed a commit
that referenced
this pull request
Nov 8, 2018
7a90b1b build: Fix windows build error if `--disable-bip70` (Chun Kuan Lee) Pull request description: Fix #14677 The SSL library seems to be used even if bip70 disabled on Windows. Tree-SHA512: 1c5fcf98048ce9e2eedf958326c11949eef74b3379a50d73751cb871d3d4323186caf607888c461a1fe1edc5f8515bd151ab247a843e7dda79f810c06309bd88
Contributor
|
It's good to have this working, but I am still a little suspicious about this fix. If anyone with more knowledge about the build system wants to take another look at this, I think that would be useful. |
dzutto
pushed a commit
to dzutto/dash
that referenced
this pull request
Aug 19, 2021
7a90b1b build: Fix windows build error if `--disable-bip70` (Chun Kuan Lee) Pull request description: Fix bitcoin#14677 The SSL library seems to be used even if bip70 disabled on Windows. Tree-SHA512: 1c5fcf98048ce9e2eedf958326c11949eef74b3379a50d73751cb871d3d4323186caf607888c461a1fe1edc5f8515bd151ab247a843e7dda79f810c06309bd88
dzutto
pushed a commit
to dzutto/dash
that referenced
this pull request
Aug 27, 2021
7a90b1b build: Fix windows build error if `--disable-bip70` (Chun Kuan Lee) Pull request description: Fix bitcoin#14677 The SSL library seems to be used even if bip70 disabled on Windows. Tree-SHA512: 1c5fcf98048ce9e2eedf958326c11949eef74b3379a50d73751cb871d3d4323186caf607888c461a1fe1edc5f8515bd151ab247a843e7dda79f810c06309bd88
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Aug 29, 2021
…5063_15411 Backport 0.18 PRs bitcoin#14451, bitcoin#14686, bitcoin#14564, bitcoin#14568,bitcoin#15063, bitcoin#15411: deprecate BIP70 and build GUI without BIP70 support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14677
The SSL library seems to be used even if bip70 disabled on Windows.