Skip to content

appveyor: Script improvement part II #14665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maflcko merged 1 commit into from
Nov 7, 2018
Merged

appveyor: Script improvement part II #14665

maflcko merged 1 commit into from
Nov 7, 2018

Conversation

@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Nov 6, 2018 •
edited
Loading

  • decrease clone depth to 5
  • Upgrade to python 3.7 that we can use PYTHONUTF8 from PEP540.
  • Set clcache version to v4.2.0
  • Do not fetch the latest vcpkg package (The issue does not exist anymore)
  • Set test_bitcoin report sink and log sink to stdout and redirect stderr to NUL to drop confusing error messages that introduced by wallet: Remove trailing separators from -walletdir arg #14146
  • discard vcpkg, bench_bitcoin output
  • Set functional test --failfast flag
  • Make the log be as clear as possible. (Only ~100 lines)

@fanquake fanquake added the Tests label Nov 6, 2018
@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 6, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #14372 (msvc: build secp256k1 and leveldb locally by ken2812221)
  • #13787 (Test for Windows encoding issue by ken2812221)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko
Copy link
Member

maflcko commented Nov 6, 2018

@sipsorcery @NicolasDorier

@NicolasDorier
Copy link
Contributor

NicolasDorier commented Nov 6, 2018

quick review ACK, but will test tomorrow.

@sipsorcery
Copy link
Contributor

sipsorcery commented Nov 7, 2018 •
edited
Loading

tACK 99d33a6

First build with the updated yaml file failed on the wallet_multiwallet.py test but the two subsequent builds passed. This is most likely a vagary of AppVeyor.

maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Nov 7, 2018
Merge bitcoin#14665: appveyor: Script improvement part II
4e6dc7a 
99d33a6 appveyor: Script improvement part II (Chun Kuan Lee)

Pull request description:

  - decrease clone depth to 5
  - Upgrade to python 3.7 that we can use `PYTHONUTF8` from PEP540.
  - Set clcache version to `v4.2.0`
  - Do not fetch the latest vcpkg package (The issue does not exist anymore)
  - Set test_bitcoin report sink and log sink to stdout and redirect stderr to NUL to drop confusing error messages that introduced by bitcoin#14146
  - discard vcpkg, bench_bitcoin output
  - Set functional test `--failfast` flag
  - Make the log be as clear as possible. (Only ~100 lines)

Tree-SHA512: e7e1f5c2698e8a5d15394edfb4b574508081e99ef4a353995f55657cb51e642567a128d6432a899ecae6f742494c143ac16e2e64df6c26e1e575421ee4a1df50
@maflcko maflcko merged commit 99d33a6 into bitcoin:master Nov 7, 2018
@ken2812221 ken2812221 deleted the appveyor-quiet branch November 7, 2018 17:46
maflcko
maflcko reviewed Dec 17, 2018
View reviewed changes
.appveyor.yml
- cmd: src\test_bitcoin.exe
- ps: src\bench_bitcoin.exe -evals=1 -scaling=0
- cmd: src\test_bitcoin.exe -k stdout -e stdout 2> NUL
- cmd: src\bench_bitcoin.exe -evals=1 -scaling=0 > NUL
Copy link
Member

@maflcko maflcko Dec 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will hide precious debug information in case of failure?

See for example 1a7cebc

Copy link
Member

@sipa sipa Dec 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoFalke No, it doesn't seem to. -k stdout is supposed to send the output to stdout anyway. I was just making sure that wasn't the problem.

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sipa sipa sipa left review comments

+1 more reviewer

@maflcko maflcko maflcko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ken2812221 @DrahtBot @maflcko @NicolasDorier @sipsorcery @sipa @fanquake