build: Remove illegal spacing in darwin.mk #14647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
Member
|
tACK 63c74d2 So However a I assume backward-incompatible changes from 3.82 or 4.0 are the problem. master (b740788): This PR (63c74d2), using |
Member
laanwj
added a commit
that referenced
this pull request
Nov 5, 2018
63c74d2 build: Remove illegal spacing in darwin.mk (Jon Layton) Pull request description: MacOS 10.13.6, `make -v` = `GNU Make 4.2.1 Built for x86_64-apple-darwin17.7.0` ``` cd depends make HOST=x86_64-apple-darwin17.7.0 ``` Results in error: ``` builders/darwin.mk:1: *** empty variable name. Stop. ``` This seems to fix it. Tree-SHA512: 3481b9418571186c123942dc95b12bcaf47acbe2099ddd4524f5bb9dfe203175d7252bb7a1aa8ca5fec82578beeacfa06299472cb9d0d627c61f09486d74756c
Contributor
|
Backport me? |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Nov 28, 2018
Github-Pull: bitcoin#14647 Rebased-From: 63c74d2
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Mar 31, 2020
Summary: Backport of core [[bitcoin/bitcoin#14647 | PR14647]]. For the sake of avoiding merge conflicts. Test Plan: Untested (by me), I trust the core devs that it is doing something. For what I see it can't hurt. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5602
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Aug 17, 2020
Summary: Backport of core [[bitcoin/bitcoin#14647 | PR14647]]. For the sake of avoiding merge conflicts. Test Plan: Untested (by me), I trust the core devs that it is doing something. For what I see it can't hurt. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5602
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 17, 2021
63c74d2 build: Remove illegal spacing in darwin.mk (Jon Layton) Pull request description: MacOS 10.13.6, `make -v` = `GNU Make 4.2.1 Built for x86_64-apple-darwin17.7.0` ``` cd depends make HOST=x86_64-apple-darwin17.7.0 ``` Results in error: ``` builders/darwin.mk:1: *** empty variable name. Stop. ``` This seems to fix it. Tree-SHA512: 3481b9418571186c123942dc95b12bcaf47acbe2099ddd4524f5bb9dfe203175d7252bb7a1aa8ca5fec82578beeacfa06299472cb9d0d627c61f09486d74756c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS 10.13.6,
make -v=GNU Make 4.2.1 Built for x86_64-apple-darwin17.7.0Results in error:
This seems to fix it.