Include full version number in released file names #14612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the build number (CLIENT_VERSION_BUILD) is non-zero, we want to include that in the package version number so the resulting binaries are named with the correct version.
Member
|
So it would show Might be nice to actually use the full version number generated from the tag, so non-tag builds get the commit hash in there... |
Member
Author
It would only show in the gitian produced files. This shouldn't effect what users would see from |
Member
|
Concept ACK
|
Contributor
|
For BitcoinCore.org, as @laanwj mentions, the regular content part of the website doesn't currently have any pages that link directly to RCs, so no changes are necessary as long as the final release files continue to use the same naming scheme. |
|
Should be okay for bitcoin.org as well, thanks. |
Member
Author
|
I've updated release-process.md to say that
Correct. |
Member
Member
|
@theuni I suppose you're ok with this? |
laanwj
added a commit
that referenced
this pull request
Nov 23, 2018
75a4bf6 Update release-process.md to include RC version bumping (Andrew Chow) 04b0bc7 build: include rc number in version number (Andrew Chow) 895e6bb build: if VERSION_BUILD is non-zero, include it in the package version (Andrew Chow) Pull request description: As noted on IRC, the filenames of the gitian build results do not contain the 4th digit of the version number if it has one, e.g. 0.17.0.1 produces files with the number 0.17.0. Furthermore, when RC's are built, the resulting filenames are of the release version and do not include `rc` in them. This occurs because `configure.ac` is written to create version numbers of the form `major.minor.rev` instead of `major.minor.rev.build` and without any rc version as it does not handle rc numbers. This PR changes `configure.ac` to include the build number if it is greater than 0. It will also include the rc number if it is greater than 0. So the filenames of the gitian builds will now contain the full version number. This behavior can be tested by setting `_CLIENT_VERSION_BUILD` and `_CLIENT_VERSION_RC` to non-zero values and then doing `make dist`. A tar file should be created with the correct versioning. Tree-SHA512: b77990485f2c7770be897dc136737cd805306afff9882ebef7170741f363203587356ccf8bec83163268ace1bd77433fbd2ba8c213f993677bfb867d99a0bbe7
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 25, 2019
298528c build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString (fanquake) 04f5d5b build: use full version string in setup.exe (MarcoFalke) c787618 Update release-process.md to include RC version bumping (Andrew Chow) 32a69da build: include rc number in version number (Andrew Chow) 8c2b28b build: if VERSION_BUILD is non-zero, include it in the package version (Andrew Chow) Pull request description: This is a backport of the following 3 upstream PRs that result in more precise file names in gitian outputs and in macOS app version info; namely that they are no longer limited to only 3 levels deep (`3.4.0` for example) and will now include the 4th level and/or the RC version if needed (`4.0.0rc1` or `4.0.0.1` for example). bitcoin#14612 bitcoin#14701 bitcoin#15548 Top commit has no ACKs. Tree-SHA512: 1195e9c0af92f4d6c2f7546530d1d5c1046f9139c8f9a03d2d8e092bbbcf5e5c5d046523e8a3712bde3d84bf81252dcc8dbb1ac3f1cdaaa863b1d14c3251fe95
lukechilds
added a commit
to lukechilds/docker-bitcoind
that referenced
this pull request
Dec 11, 2019
lukechilds
added a commit
to lukechilds/docker-bitcoind
that referenced
this pull request
Dec 11, 2019
TheHolyRoger
added a commit
to TheHolyRogerCoin/TheHolyRogerCoin
that referenced
this pull request
Jul 26, 2020
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Aug 11, 2021
75a4bf6 Update release-process.md to include RC version bumping (Andrew Chow) 04b0bc7 build: include rc number in version number (Andrew Chow) 895e6bb build: if VERSION_BUILD is non-zero, include it in the package version (Andrew Chow) Pull request description: As noted on IRC, the filenames of the gitian build results do not contain the 4th digit of the version number if it has one, e.g. 0.17.0.1 produces files with the number 0.17.0. Furthermore, when RC's are built, the resulting filenames are of the release version and do not include `rc` in them. This occurs because `configure.ac` is written to create version numbers of the form `major.minor.rev` instead of `major.minor.rev.build` and without any rc version as it does not handle rc numbers. This PR changes `configure.ac` to include the build number if it is greater than 0. It will also include the rc number if it is greater than 0. So the filenames of the gitian builds will now contain the full version number. This behavior can be tested by setting `_CLIENT_VERSION_BUILD` and `_CLIENT_VERSION_RC` to non-zero values and then doing `make dist`. A tar file should be created with the correct versioning. Tree-SHA512: b77990485f2c7770be897dc136737cd805306afff9882ebef7170741f363203587356ccf8bec83163268ace1bd77433fbd2ba8c213f993677bfb867d99a0bbe7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted on IRC, the filenames of the gitian build results do not contain the 4th digit of the version number if it has one, e.g. 0.17.0.1 produces files with the number 0.17.0. Furthermore, when RC's are built, the resulting filenames are of the release version and do not include
rcin them. This occurs becauseconfigure.acis written to create version numbers of the formmajor.minor.revinstead ofmajor.minor.rev.buildand without any rc version as it does not handle rc numbers.This PR changes
configure.acto include the build number if it is greater than 0. It will also include the rc number if it is greater than 0. So the filenames of the gitian builds will now contain the full version number.This behavior can be tested by setting
_CLIENT_VERSION_BUILDand_CLIENT_VERSION_RCto non-zero values and then doingmake dist. A tar file should be created with the correct versioning.