qt: Remove the "Pay only required fee..." checkbox #14608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds functions for specifing a min/max value for a BitcoinAmountField. These options only affect user input, so it's still possible to use setValue to set values outside of the min/max range. The existing value will not be changed when calling these functions even if it's out of range. The min/max range will be reinforced when the field loses focus. This also adds `SetAllowEmpty` function which specifies if the field is allowed to be left empty by the user. If set to false the field will be set to the minimum allowed value if it's empty when focus is lost.
The custom fee input box now has a minimum value equal to the minimum required fee. Before a value below the minimum fee could be entered which was confusing since the minimum fee would still be paid even though a lower amount was entered.
Member
|
tACK a16f44c on macOS 10.14.1 It doesn't make sense to cap the max fee rate at 21 000 000 BTC per kilobyte, but there's no harm either. |
Contributor
|
Concept ACK |
Member
|
utACK a16f44c |
Member
|
Concept ACK |
Contributor
|
Tested ACK a16f44c |
jonasschnelli
added a commit
that referenced
this pull request
Nov 13, 2018
a16f44c qt: Remove "Pay only required fee" checkbox (Hennadii Stepanov) 8711cc0 qt: Improve BitcoinAmountField class (Hennadii Stepanov) Pull request description: Ref #13280 This PR removes the "Pay only the required fee..." checkbox from the custom transaction fee section in the "Send" tab. Instead, a minimum value will be enforced on the custom fee input box. All comments from #13280 are addressed. Before:  After:  cc: @promag @MarcoFalke @Sjors Tree-SHA512: 073577d38d8353b10e8f36fb52e3c6e81dd45d25d84df9b9e4f78f452ff0bdbff3e225bdd6122b5a03839ffdcc2a2a08175f81c2541cf2d12918536abbfa3fd1
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 29, 2020
Summary: > This adds functions for specifing a min/max value for a BitcoinAmountField. These options only affect user input, so it's still possible to use setValue to set values outside of the min/max range. The existing value will not be changed when calling these functions even if it's out of range. The min/max range will be reinforced when the field loses focus. > This also adds `SetAllowEmpty` function which specifies if the field is allowed to be left empty by the user. If set to false the field will be set to the minimum allowed value if it's empty when focus is lost. This is a backport of Core [[bitcoin/bitcoin#14608 | PR14608]] [1/2] Commit: bitcoin/bitcoin@8711cc0 Depends on D8177. Test Plan: `ninja && src/qt/bitcoin-qt` Verify that in the spend tab you cannot set amount or fees larger than 21 MBCH or lower than 0. Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D8176
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 29, 2020
Summary: > The custom fee input box now has a minimum value equal to the minimum > required fee. Before a value below the minimum fee could be entered > which was confusing since the minimum fee would still be paid even > though a lower amount was entered. Backport of Core [[bitcoin/bitcoin#14608 | PR14608]] [2/2] Commit bitcoin/bitcoin@a16f44c Depends on D8176 Test Plan: `ninja && src/qt/bitcoin-qt -regtest` On the Spend page, custom fee section, verify that the "Pay only required fee" checkbox is no longer there and is replaced by a simple label. Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D8178
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #13280
This PR removes the "Pay only the required fee..." checkbox from the custom transaction fee section in the "Send" tab. Instead, a minimum value will be enforced on the custom fee input box.
All comments from #13280 are addressed.
Before:
After:
cc: @promag @MarcoFalke @Sjors