-
Notifications
You must be signed in to change notification settings - Fork 38.6k
Reorganize tray icon menu into more logical order #1459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The current order of menu options in the tray menu doesn't really match expected usage patterns, this commit changes it to more logical order. - Toggle show/hide first (unchanged) - Then, send/receive coins actions, which are the critical functionality of bitcoin - Then, sign/verify message - Then finally the options, and closing with the debug window
|
ACK, one unrelated thing can you explain what FIRST_CLASS_MESSAGING is or does for us UI wise? |
|
Basically, it makes that sign/verify message are tabs instead of separate windows. lukejr introduced it in one of his commits, because according to him signmessage is as important (and thus should be as prominent) as sending coins, but I don't think anyone apart from him agrees and/or uses the feature. |
Reorganize tray icon menu into more logical order
|
I have a pull in the pipe that merges sign / verify message to a tabbed UI just like with the options dialog. Will open it later today or tomorrow ... perhaps we can talk about removing that unused stuff? Are there any comparison screens how it looks with that messaging stuff? That many #ifdefs for such a thing annoy me! |
|
I don't think there is a need to do that, better to keep it like this, it will only result in endless bikeshedding discussions. |
Reorganize tray icon menu into more logical order
* Make strWalletFile const * Insert Line Space for Legibility
bitcoin#1459) …initial sync The reindex or sync process can be severely lengthened in time due to the compaction process falling behind. There are settings in leveldb that prevent writing to the database in the event that there are 12 uncompacted Level-0 files. This causes bitcoin to halt the sync/reindex process until compaction has reduced the number of files neededing compaction. This causes delays and hangups in the bitcoin process which gives the appearance that the node is hung...and indeed it is for a time. Furthermore this halting process is very apparent when running with -tindex=1, which creates even more compaction which then conflicts with the compaction happening in the utxo set. Set the leveldb stop write trigger to 4096 files (up from just 12). This should prevent, even on slower and memory deficient systems, from hitting the limits and stopping the sync or reindex process. NOTE: this halting process can be easily seen by running with txindex=1 and syncing or reindexing on a spinning disk. This issues was first brought up a few months back from, I believe @digitsu , who was having a very slow sync when running with txindex=1. TESTING NOTE: Testing without this patch and reindexing on a spinning disk with -txindex=1, yeilded took 9hr 12min, while with the patch 4hr 10 min; And while the reindex with patch finished much faster, there is a period of time after the reindex is complete where performance is slightly degraded until the compactions are complete. However by running a few getrawtransactions which hit the txindex the degradation is not all that much, (still sub second retrievals) and block processing performance doesn't seem to be impacted during this compaction period.
5c8e968 [Trivial] Document logtimemicros flag in the help (random-zebra) 4daa10a util: Store debug log file path in BCLog::Logger member. (random-zebra) 2f03e85 scripted-diff: Rename BCLog::Logger member variables. (random-zebra) 303700e util: Refactor GetLogCategory. (random-zebra) 0ae18c0 util: Encapsulate logCategories within BCLog::Logger. (random-zebra) a2fb3fd util: Move debug file management functions into Logger. (random-zebra) 5a42d82 util: Establish global logger object. (random-zebra) 15c0da4 [Refactor] Complete boost::filesystem namespace in util (random-zebra) 81ddbf4 MOVEONLY: Move logging code from util.{h,cpp} to new files. (random-zebra) Pull request description: Implemented on top of: - [x] bitcoin#1449 - [x] bitcoin#1437 - [x] bitcoin#1439 - [x] bitcoin#1450 - [x] bitcoin#1451 - [x] bitcoin#1455 This creates a new class BCLog::Logger to encapsulate all global logging configuration and state. Adapted from - bitcoin#13021 - bitcoin#12954 ACKs for top commit: Fuzzbawls: ACK 5c8e968 furszy: utACK 5c8e968 Tree-SHA512: 0b10a031dd7e32b48485236fbdd8249d011049e6f99e1df145b7dea4cab9e6e67e19d1bb13ff48e99eb2487a8399bbb8298fe851ad8873416fc1053aee0379bc
The current order of menu options in the tray menu doesn't really match expected usage patterns, this commit changes it to more logical order.