build: Fix Qt link order for Windows build #14568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
great! can you please explain how swapping these around fixes the build? something with qt depending on libssl? |
Member
|
Concept ACK. |
Contributor
Author
|
Contributor
|
Any idea why the link order here only seems to cause issues on windows builds and not linux/osx? |
Contributor
|
Gitian builds for commit 754a00d (master):
Gitian builds for commit 3dbc5bc94e8ebfdcfac57f76b987eb17a7a92aa5 (master and this pull):
|
maflcko
pushed a commit
that referenced
this pull request
Oct 26, 2018
fbaccbf build: Fix Qt link order for Windows build (Chun Kuan Lee) Pull request description: See #14451 (comment) Tree-SHA512: 819e68dc750297a74d04aa1ad3dae64072b66df718d36b950bd9430c9fca1771c611af934df23954f81b83bd89f96ea76c20cbf17db1364b988a6c34c43fb631
dzutto
pushed a commit
to dzutto/dash
that referenced
this pull request
Aug 19, 2021
fbaccbf build: Fix Qt link order for Windows build (Chun Kuan Lee) Pull request description: See bitcoin#14451 (comment) Tree-SHA512: 819e68dc750297a74d04aa1ad3dae64072b66df718d36b950bd9430c9fca1771c611af934df23954f81b83bd89f96ea76c20cbf17db1364b988a6c34c43fb631
dzutto
pushed a commit
to dzutto/dash
that referenced
this pull request
Aug 27, 2021
fbaccbf build: Fix Qt link order for Windows build (Chun Kuan Lee) Pull request description: See bitcoin#14451 (comment) Tree-SHA512: 819e68dc750297a74d04aa1ad3dae64072b66df718d36b950bd9430c9fca1771c611af934df23954f81b83bd89f96ea76c20cbf17db1364b988a6c34c43fb631
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Aug 29, 2021
…5063_15411 Backport 0.18 PRs bitcoin#14451, bitcoin#14686, bitcoin#14564, bitcoin#14568,bitcoin#15063, bitcoin#15411: deprecate BIP70 and build GUI without BIP70 support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #14451 (comment)