Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI #14564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
tACK 3852aff on macOS 10.14 With protobuf installed: Without protobuf installed: Without protobuf installed, with (when checking out this branch for the first time, you need a |
Contributor
Author
|
I think |
Member
|
testing 3852aff: with protobuf and with protobuf and without protobuf and without protobuf and |
Contributor
|
Gitian builds for commit f4e4ea1 (master):
Gitian builds for commit 5d78c857f3117cacaea4275b474c164e3e88bbd2 (master and this pull):
|
Member
|
Gitian fails with |
Member
|
Travis failure: |
Contributor
Author
|
@ken2812221 does this seem to be a similar issue to #14568? |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
jameshilliard
force-pushed
the
bip70-disable-check
branch
from
3852aff to
6f19c10
Compare
…ing instead of the GUI
jameshilliard
force-pushed
the
bip70-disable-check
branch
from
6f19c10 to
58c5cc9
Compare
jameshilliard
commented
Nov 10, 2018
Contributor
Author
|
This should be fixed now, can we trigger a new gitian test build? |
Contributor
|
Gitian builds for commit edc7152 (master):
Gitian builds for commit 8ba6b08d0066e507298f5f1f2261d2f7ffd0e588 (master and this pull):
|
Contributor
|
utACK |
maflcko
pushed a commit
that referenced
this pull request
Dec 6, 2018
…otobuf is missing instead of the GUI 58c5cc9 Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI (James Hilliard) Pull request description: This change ensures that the GUI is still built even if protobuf is missing unless --enable-bip70 is passed to configure. If protobuf is present bip70 support will be compiled in unless --disable-bip70 is passed. Tree-SHA512: 432d2fbefec5436503d8aa8994e4efaf760d88bfd5249af031b502b356852e8fd56362f86420f9ffe78498649079d0f1b68c327960b215d83c275800626ad275
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Dec 24, 2018
…ing instead of the GUI Github-Pull: bitcoin#14564 Rebased-From: 58c5cc9
dzutto
pushed a commit
to dzutto/dash
that referenced
this pull request
Aug 19, 2021
…when protobuf is missing instead of the GUI 58c5cc9 Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI (James Hilliard) Pull request description: This change ensures that the GUI is still built even if protobuf is missing unless --enable-bip70 is passed to configure. If protobuf is present bip70 support will be compiled in unless --disable-bip70 is passed. Tree-SHA512: 432d2fbefec5436503d8aa8994e4efaf760d88bfd5249af031b502b356852e8fd56362f86420f9ffe78498649079d0f1b68c327960b215d83c275800626ad275
dzutto
pushed a commit
to dzutto/dash
that referenced
this pull request
Aug 27, 2021
…when protobuf is missing instead of the GUI 58c5cc9 Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI (James Hilliard) Pull request description: This change ensures that the GUI is still built even if protobuf is missing unless --enable-bip70 is passed to configure. If protobuf is present bip70 support will be compiled in unless --disable-bip70 is passed. Tree-SHA512: 432d2fbefec5436503d8aa8994e4efaf760d88bfd5249af031b502b356852e8fd56362f86420f9ffe78498649079d0f1b68c327960b215d83c275800626ad275
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Aug 29, 2021
…5063_15411 Backport 0.18 PRs bitcoin#14451, bitcoin#14686, bitcoin#14564, bitcoin#14568,bitcoin#15063, bitcoin#15411: deprecate BIP70 and build GUI without BIP70 support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the GUI is still built even if protobuf is missing unless --enable-bip70 is passed to configure. If protobuf is present bip70 support will be compiled in unless --disable-bip70 is passed.