appveyor: Enable multiwallet tests #14559
Merged
+9
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Concept ACK Thanks for all your good appveyor work! |
src/wallet/db.cpp
Outdated
| env = nullptr; | ||
| } else { | ||
| // To avoid accessing a map that has already deconstructed, do not call this when shutdown is true. g_dbenvs.erase would also erase this value. | ||
| // TODO: get rid of wild pointers |
Contributor
There was a problem hiding this comment.
Wild pointers – scary stuff! Would you be able to construct a test case triggering that? What would it take to get rid of them?
Contributor
Author
There was a problem hiding this comment.
@practicalswift This is the code from #14320. Better to move to here. It might can be resolved by #11911
promag
reviewed
Oct 24, 2018
| self.restart_node(0, extra_args) | ||
|
|
||
| assert_equal(set(map(lambda w: w['name'], self.nodes[0].listwalletdir()['wallets'])), set(['', 'w3', 'w2', 'sub/w5', 'w7', 'w7', 'w8_copy', 'w1', 'w8', 'w'])) | ||
| assert_equal(set(map(lambda w: w['name'], self.nodes[0].listwalletdir()['wallets'])), set(['', 'w3', 'w2', os.path.join('sub', 'w5'), 'w7', 'w7', 'w8_copy', 'w1', 'w8', 'w'])) |
Contributor
There was a problem hiding this comment.
In windows it is possible to set -wallet=sub/w5, listwallets gives sub/w5 but listwalletdir gives sub\w5?
Contributor
Author
There was a problem hiding this comment.
Yes, unless we change to calling fs::path::generic_string() instead of calling fs::path::string()
This was referenced Oct 24, 2018
Contributor
Author
Contributor
|
utACK 4dca7d0. |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 24, 2018
4dca7d0 appveyor: Enable multiwallet test (Chun Kuan Lee) Pull request description: Based on bitcoin#14320 This PR enable multiwallet test on appveyor. Also re-enable symlink tests on Windows which is available after Windows Vista. I disable these tests in bitcoin#13964 because I suppose that Windows does not support symlink, but I was wrong. Tree-SHA512: 852cd4dedf36ec9c34aff8926cb34e6a560aea0bb9170c7a2264fc292dbb605622d561568d8df39aeb90d3d2bb700901d218ea7e7c5e21d84827c40d6370b369
laanwj
added a commit
that referenced
this pull request
Oct 26, 2018
ed2e183 Remove fs::relative call and fix listwalletdir tests (João Barbosa) Pull request description: The implementation of `fs::relative` resolves symlinks which is not intended in ListWalletDir. The replacement does what is required, and `listwalletdir` RPC tests are fixed accordingly. Also, `fs::recursive_directory_iterator` iteration is fixed to build with boost 1.47. Based on #14559 Tree-SHA512: 1da516226073f195285d10d9d9648c90cce0158c5d1eb9c31217bb4abb575cd37f07c00787c5a850554d6120bbc5a3cbc5cb47d4488b32ac6bcb52bc1882d600
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Mar 24, 2020
Summary: Partial backport of [[bitcoin/bitcoin#14559 | PR14559]] to better match Core Test Plan: ``` test_runner.py wallet_multiwallet ``` Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5546
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Aug 17, 2020
Summary: Partial backport of [[bitcoin/bitcoin#14559 | PR14559]] to better match Core Test Plan: ``` test_runner.py wallet_multiwallet ``` Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5546
5tefan
added a commit
to 5tefan/dash
that referenced
this pull request
Aug 14, 2021
4dca7d0 appveyor: Enable multiwallet test (Chun Kuan Lee) Pull request description: Based on bitcoin#14320 This PR enable multiwallet test on appveyor. Also re-enable symlink tests on Windows which is available after Windows Vista. I disable these tests in bitcoin#13964 because I suppose that Windows does not support symlink, but I was wrong. Tree-SHA512: 852cd4dedf36ec9c34aff8926cb34e6a560aea0bb9170c7a2264fc292dbb605622d561568d8df39aeb90d3d2bb700901d218ea7e7c5e21d84827c40d6370b369
5tefan
added a commit
to 5tefan/dash
that referenced
this pull request
Aug 14, 2021
…ests ed2e183 Remove fs::relative call and fix listwalletdir tests (João Barbosa) Pull request description: The implementation of `fs::relative` resolves symlinks which is not intended in ListWalletDir. The replacement does what is required, and `listwalletdir` RPC tests are fixed accordingly. Also, `fs::recursive_directory_iterator` iteration is fixed to build with boost 1.47. Based on bitcoin#14559 Tree-SHA512: 1da516226073f195285d10d9d9648c90cce0158c5d1eb9c31217bb4abb575cd37f07c00787c5a850554d6120bbc5a3cbc5cb47d4488b32ac6bcb52bc1882d600
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Aug 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #14320
This PR enable multiwallet test on appveyor. Also re-enable symlink tests on Windows which is available after Windows Vista.
I disable these tests in #13964 because I suppose that Windows does not support symlink, but I was wrong.