Add compile time checking for cs_main locks which we assert at run time #14444
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
practicalswift
force-pushed
the
move-runtime-checking-to-compile-time-checking
branch
from
5fe26f8 to
9bc0e80
Compare
Contributor
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
@practicalswift FYI #13783 (comment) maybe you should defer these changes? |
Member
|
@practicalswift In a similar vein to my comment here, please remove the |
Member
|
Agree with the previous feedback, also please squash your commits. |
practicalswift
force-pushed
the
move-runtime-checking-to-compile-time-checking
branch
from
9bc0e80 to
0089905
Compare
Contributor
Author
|
@promag @fanquake @MarcoFalke Thanks for the quick review and the clear feedback. Feedback addressed. Please re-review. |
practicalswift
changed the title
Contributor
|
utACK 0089905. |
Member
|
utACK 0089905 |
maflcko
pushed a commit
that referenced
this pull request
Oct 24, 2018
…sert at run time 0089905 Add compile time checking for cs_main locks which we assert at run time (practicalswift) Pull request description: Assert locking requirements at compile-time (`EXCLUSIVE_LOCKS_REQUIRED(foo)`) instead of at run-time (`AssertLockHeld(…)`). Tree-SHA512: f4965ebf4bb5dbf5e7ed738cacf82c0f6cd55134fb968860bf84a84e29806485617f223910bb8c5461213f1829b0137c64ba1f6d6a2008b3cac3bb3a28df9324
30 tasks
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 25, 2019
…sert at run time Summary: 0089905361 Add compile time checking for cs_main locks which we assert at run time (practicalswift) Pull request description: Assert locking requirements at compile-time (`EXCLUSIVE_LOCKS_REQUIRED(foo)`) instead of at run-time (`AssertLockHeld(…)`). Tree-SHA512: f4965ebf4bb5dbf5e7ed738cacf82c0f6cd55134fb968860bf84a84e29806485617f223910bb8c5461213f1829b0137c64ba1f6d6a2008b3cac3bb3a28df9324 Backport of Core PR14444 bitcoin/bitcoin#14444 Test Plan: ../configure CXX=clang++ CC=clang make check Run teamcity `build-werror` Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D4225
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Dec 27, 2019
…sert at run time Summary: 0089905361 Add compile time checking for cs_main locks which we assert at run time (practicalswift) Pull request description: Assert locking requirements at compile-time (`EXCLUSIVE_LOCKS_REQUIRED(foo)`) instead of at run-time (`AssertLockHeld(…)`). Tree-SHA512: f4965ebf4bb5dbf5e7ed738cacf82c0f6cd55134fb968860bf84a84e29806485617f223910bb8c5461213f1829b0137c64ba1f6d6a2008b3cac3bb3a28df9324 Backport of Core PR14444 bitcoin/bitcoin#14444 Test Plan: ../configure CXX=clang++ CC=clang make check Run teamcity `build-werror` Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D4225
jonspock
pushed a commit
to devaultcrypto/devault
that referenced
this pull request
Dec 29, 2019
…sert at run time Summary: 0089905361 Add compile time checking for cs_main locks which we assert at run time (practicalswift) Pull request description: Assert locking requirements at compile-time (`EXCLUSIVE_LOCKS_REQUIRED(foo)`) instead of at run-time (`AssertLockHeld(…)`). Tree-SHA512: f4965ebf4bb5dbf5e7ed738cacf82c0f6cd55134fb968860bf84a84e29806485617f223910bb8c5461213f1829b0137c64ba1f6d6a2008b3cac3bb3a28df9324 Backport of Core PR14444 bitcoin/bitcoin#14444 Test Plan: ../configure CXX=clang++ CC=clang make check Run teamcity `build-werror` Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D4225
practicalswift
deleted the
move-runtime-checking-to-compile-time-checking
branch
LarryRuane
pushed a commit
to LarryRuane/zcash
that referenced
this pull request
Apr 29, 2021
zcash: cherry picked from commit 0089905 zcash: bitcoin/bitcoin#14444
LarryRuane
pushed a commit
to LarryRuane/zcash
that referenced
this pull request
Jun 1, 2021
zcash: cherry picked from commit 0089905 zcash: bitcoin/bitcoin#14444
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 17, 2021
…h we assert at run time 0089905 Add compile time checking for cs_main locks which we assert at run time (practicalswift) Pull request description: Assert locking requirements at compile-time (`EXCLUSIVE_LOCKS_REQUIRED(foo)`) instead of at run-time (`AssertLockHeld(…)`). Tree-SHA512: f4965ebf4bb5dbf5e7ed738cacf82c0f6cd55134fb968860bf84a84e29806485617f223910bb8c5461213f1829b0137c64ba1f6d6a2008b3cac3bb3a28df9324
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert locking requirements at compile-time (
EXCLUSIVE_LOCKS_REQUIRED(foo)) instead of at run-time (AssertLockHeld(…)).