-
Notifications
You must be signed in to change notification settings - Fork 38.7k
doc: mention that macOS system headers now require manual installation #14352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63364a1 to
9860689
Compare
DocOBITCOIN
approved these changes
Sep 30, 2018
Contributor
|
I guess this not necessary for those that update from a working development environment? |
Member
|
I don't think this is the right thing to do. Instead, we should be making sure that the SDK is used as the sysroot as intended. |
Member
Author
|
@theuni I'll close this for now. Anyone that runs into the problem can find this PR, or the discussion in other issues. |
Member
|
Trying the proper (?) solution in #17118 |
laanwj
added a commit
that referenced
this pull request
Oct 16, 2019
a0daea4 [build] depends macOS: point --sysroot to SDK (Sjors Provoost) Pull request description: Fixes errors like `fatal error: 'unistd.h' file not found` when building depends on macOS. Replaces #14352 (which doesn't work on Catalina). ACKs for top commit: jonasschnelli: utACK a0daea4 Tree-SHA512: 995b1e1e84e635b32d1d4038bc63730c94a7c318b7240f6d62825977e5c97fe52c5aa5a0f39070beb0df8271dd294b36d6b5cf7f09ad07494fb15d5bd4d77f68
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Oct 17, 2019
a0daea4 [build] depends macOS: point --sysroot to SDK (Sjors Provoost) Pull request description: Fixes errors like `fatal error: 'unistd.h' file not found` when building depends on macOS. Replaces bitcoin#14352 (which doesn't work on Catalina). ACKs for top commit: jonasschnelli: utACK a0daea4 Tree-SHA512: 995b1e1e84e635b32d1d4038bc63730c94a7c318b7240f6d62825977e5c97fe52c5aa5a0f39070beb0df8271dd294b36d6b5cf7f09ad07494fb15d5bd4d77f68
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Oct 19, 2019
) a0daea4 [build] depends macOS: point --sysroot to SDK (Sjors Provoost) Pull request description: Fixes errors like `fatal error: 'unistd.h' file not found` when building depends on macOS. Replaces bitcoin#14352 (which doesn't work on Catalina). ACKs for top commit: jonasschnelli: utACK a0daea4 Tree-SHA512: 995b1e1e84e635b32d1d4038bc63730c94a7c318b7240f6d62825977e5c97fe52c5aa5a0f39070beb0df8271dd294b36d6b5cf7f09ad07494fb15d5bd4d77f68
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Nov 19, 2019
…shpay#3161) a0daea4 [build] depends macOS: point --sysroot to SDK (Sjors Provoost) Pull request description: Fixes errors like `fatal error: 'unistd.h' file not found` when building depends on macOS. Replaces bitcoin#14352 (which doesn't work on Catalina). ACKs for top commit: jonasschnelli: utACK a0daea4 Tree-SHA512: 995b1e1e84e635b32d1d4038bc63730c94a7c318b7240f6d62825977e5c97fe52c5aa5a0f39070beb0df8271dd294b36d6b5cf7f09ad07494fb15d5bd4d77f68
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Xcode 10.0, installing the macOS Command Line Tools no longer installs the macOS system headers into
/usr/include/(this behaviour is seemingly deprecated).This means that building some dependencies using
dependswill fail like:/Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkgis provided as a work around to install the system headers into/usr/include/. This has come up once already, so probably worth documenting in the macOS build notes.