Make IPv6 support optional again (defaults to enabled) #1431
Conversation
src/init.cpp
Outdated
There was a problem hiding this comment.
Shouldn't this be !defined(USE_IPV6) || !USE_IPV6 ?
There was a problem hiding this comment.
If USE_IPV6 is not defined, then there's no support compiled in to disable.
|
IPv6 support should be enabled by default, disabled by necessity. |
|
@jgarzik That's what this does... |
|
What is the practical difference between USE_IPV6=0 and USE_IPV6=-? One compiles it in, but leaves no way to use it, the other just doesn't compile it in. |
|
-onlynet=ipv6 should work, no? |
|
If you call SetLimited(NET_IPV6) explicitly, -onlynet=ipv6 will just disable all other networks, and there won't be any network left. |
|
That's why it's in an 'else' clause |
|
Oops, missed that in the diff. ACK. |
|
Found and fixed some build bugs:
|
|
weak ACK. Would prefer a better system for including and overriding USE_FOO defaults. Some build systems look for a file "makefile.local" or "makefile.cfg" or whatever. If it exists, read it and use it to adjust the defaults. |
|
GNUmakefile can be used for that purpose (I do this). |
|
Would be nice to not introduce something that does not work on Windows or makes building even harder to do @GNUmakefile ;). |
|
@Diapolo GNUmakefile is more of an out-of-tree config thing. Windows has .BAT files :P |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/751b8eb120375a1a045d55f267d2d93d807ab649 for binaries and test log. |
|
ACK. |
Make IPv6 support optional again (defaults to enabled)
|
So with Qt, now do I need to supply "USE_IPV6=1" or is that also default for Qt ^^? |
|
It's default. |
|
It has been default for a long time. IPv6 is not exactly experimental anymore :) |
V0.12.2.x merge upstream
53cfbee [GUI] Automatic wallet backup after upgrade to HD (random-zebra) Pull request description: Based on - [x] bitcoin#1387 Offer the option to directly backup the wallet after upgrade-to-HD (and successive re-lock) is completed. The message on the initial dialog is changed (from "Note that you will need to MAKE A NEW BACKUP.."):  If the user clicks "OK", and the wallet is locked, the unlock dialog is directly shown (as per bitcoin#1387)  After the upgrade, the client directly presents this dialog:  If the user clicks "OK", then the open-file dialog is presented, so the user can select the filename for the backup file and click "Save" completing the flow. If the user clicks "CANCEL" (or dismisses the open-file dialog later), a snackbar popup warns the user, telling to remember to backup asap. ACKs for top commit: furszy: Tested ACK 53cfbee. Fuzzbawls: ACK 53cfbee Tree-SHA512: 80fbcdb4d9805d75db98a0f394840f734314e6d249539997f1948cd7775ac2a81239b762386b7770c6ca4b8a2c38acdf1d5ae7ee7f07591bfdfc7dd4ee39cfc2
7 participants
No description provided.