refactor: Lift prevector default vals to the member declaration #14266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Are there any performance or other implications? |
Contributor
Author
|
Main argument for this is that it is protective against another constructor being added but neglecting to initialize these vars properly. |
Contributor
|
utACK d2eee87, change looks good because members are always initialized. |
Contributor
|
utACK d2eee87 nice one. nit: perhaps initialize |
Contributor
|
utACK d2eee87 |
Member
|
@sipa can you have a look at this please |
Member
|
@MarcoFalke I expect that this will have no effect on performance (the default initializers being invoked instead of delegating to the default constructor should do the exact same thing). utACK |
Contributor
|
utACK d2eee87 |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
Contributor
|
Current version has four utACK:s -- ready for merge? :-) |
Contributor
Author
|
Five ;) |
Contributor
|
utACK d2eee87 |
maflcko
changed the title
maflcko
pushed a commit
that referenced
this pull request
May 6, 2019
…laration d2eee87 Lift prevector default vals to the member declaration (Ben Woosley) Pull request description: I overlooked this possibility in #14028 ACKs for commit d2eee8: promag: utACK d2eee87, change looks good because members are always initialized. 251Labs: utACK d2eee87 nice one. ken2812221: utACK d2eee87 practicalswift: utACK d2eee87 scravy: utACK d2eee87 Tree-SHA512: f2726bae1cf892fd680cf8571027bcdc2e42ba567eaa901fb5fb5423b4d11b29e745e0163d82cb513d8c81399cc85933a16ed66d4a30829382d4721ffc41dc97
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 7, 2019
…ber declaration d2eee87 Lift prevector default vals to the member declaration (Ben Woosley) Pull request description: I overlooked this possibility in bitcoin#14028 ACKs for commit d2eee8: promag: utACK d2eee87, change looks good because members are always initialized. 251Labs: utACK d2eee87 nice one. ken2812221: utACK d2eee87 practicalswift: utACK d2eee87 scravy: utACK d2eee87 Tree-SHA512: f2726bae1cf892fd680cf8571027bcdc2e42ba567eaa901fb5fb5423b4d11b29e745e0163d82cb513d8c81399cc85933a16ed66d4a30829382d4721ffc41dc97
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
May 22, 2020
…zation 30e975e Lift prevector default vals to the member declaration (random-zebra) 3217b2b Name union to prevent compiler warning (random-zebra) Pull request description: Two simple additions to `prevector` class: - name the union, to prevent compiler warnings emitted by clang (from bitcoin#7146) - use non-static data member initializers for `_size` and `_union` (from bitcoin#14266) ACKs for top commit: furszy: utACK 30e975e Fuzzbawls: utACK 30e975e Tree-SHA512: f7a0dd55bbf2df0b9d0d72967ac00c476aebde936499cd3d1b5a7552aded6b7022c5a23c859eaa3599875f2c2c7bd737afdda3cd31db9d7e2c5dfdca7f0c9809
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
…ber declaration d2eee87 Lift prevector default vals to the member declaration (Ben Woosley) Pull request description: I overlooked this possibility in bitcoin#14028 ACKs for commit d2eee8: promag: utACK d2eee87, change looks good because members are always initialized. 251Labs: utACK d2eee87 nice one. ken2812221: utACK d2eee87 practicalswift: utACK d2eee87 scravy: utACK d2eee87 Tree-SHA512: f2726bae1cf892fd680cf8571027bcdc2e42ba567eaa901fb5fb5423b4d11b29e745e0163d82cb513d8c81399cc85933a16ed66d4a30829382d4721ffc41dc97
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 10, 2021
…ber declaration d2eee87 Lift prevector default vals to the member declaration (Ben Woosley) Pull request description: I overlooked this possibility in bitcoin#14028 ACKs for commit d2eee8: promag: utACK d2eee87, change looks good because members are always initialized. 251Labs: utACK d2eee87 nice one. ken2812221: utACK d2eee87 practicalswift: utACK d2eee87 scravy: utACK d2eee87 Tree-SHA512: f2726bae1cf892fd680cf8571027bcdc2e42ba567eaa901fb5fb5423b4d11b29e745e0163d82cb513d8c81399cc85933a16ed66d4a30829382d4721ffc41dc97
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I overlooked this possibility in #14028