Skip to content

Conversation

@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Sep 17, 2018

  • Reduce cache size from 1.55GB to 170MB by disabling whole program optimization.
  • The *.iobj *.ipdb cache is no longer required because of above change.
  • Clearing cache hit stats instead of deleting clcache stats.txt file
  • Enable access time on Windows so clcache would work correctly
  • Reduce max cache size from 2GB to 512MB (Uncompressed)
  • Remove unnecessary boost-interprocess vcpkg package
  • Split some command into multiple lines to make it easier to know what commands do.

@fanquake fanquake added the Tests label Sep 17, 2018
@DrahtBot
Copy link
Contributor

DrahtBot commented Sep 17, 2018

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot
Copy link
Contributor

Coverage Change (pull 14241) Reference (master)
Lines +0.0485 % 87.0361 %
Functions +0.1390 % 84.1130 %
Branches +0.0171 % 51.5451 %

@ken2812221 ken2812221 changed the title appveyor: trivial build cache improvement appveyor: script improvement Oct 2, 2018
@jb55
Copy link
Contributor

jb55 commented Oct 4, 2018 via email

.appveyor.yml Outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to replace the install+upgrade with

>vcpkg remove --recurse --outdated
>vcpkg install %ALL_PACKAGES%

Otherwise, you'll be rebuilding packages that you no longer use (like boost interprocess).

You should also run ./bootstrap-vcpkg.bat after doing a git pull, because there may be important tool changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

My original thought is that we could get rid of boost-interprocess by clear the cache, but if we use the command you provide, we don't have to clear the cache anymore. Just have to wait for next boost-interprocess update and it would be removed automatically.

@maflcko maflcko merged commit 59a50c2 into bitcoin:master Oct 8, 2018
maflcko pushed a commit that referenced this pull request Oct 8, 2018
59a50c2 appveyor: trivial build cache modifications (Chun Kuan Lee)

Pull request description:

  - Reduce cache size from 1.55GB to 170MB by disabling whole program optimization.
  - The `*.iobj` `*.ipdb` cache is no longer required because of above change.
  - Clearing cache hit stats instead of deleting clcache stats.txt file
  - Enable access time on Windows so clcache would work correctly
  - Reduce max cache size from 2GB to 512MB (Uncompressed)
  - Remove unnecessary `boost-interprocess` vcpkg package
  - Split some command into multiple lines to make it easier to know what commands do.

Tree-SHA512: 070b3ee05cd4323cef6fdab5ca0f223a5aa178f09b64d41fa39d0495f9bf3a387eadd10f5b72a2cd5b6f91579f19f595450fcf0afc05d7c5f6059a79fefaadc0
@ken2812221 ken2812221 deleted the 2018-09-17-appveyor-reduce-cache branch October 8, 2018 03:49
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants