• tests: Write the notification message to different files to avoid race condition in feature_notifications.py #14275 (tests: Write the notification message to different files to avoid race condition in feature_notifications.py by ken2812221)
• tests: Run functional test on Windows and enable it on Appveyor #14007 (tests: Run functional test on Windows and enable it on Appveyor by ken2812221)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

I don't think this change is a great idea because while it fixes one place where we are using non-ascii filenames, if we want to write new tests in the future that use non-ascii filenames (or non-ascii command line arguments), this will not be sufficient, and we'll have to add similar workarounds in those places.

It would seem better if you could add ENV LANG C.UTF-8 to your dockerfile, or update to python 3.7 where this should not be an issue (https://bugs.python.org/issue28180).

There are some checks for Unicode before in the file here. So, if this is being enforced we should cleanup that code here to be consistent.

@sanket1729 We allow unicode wallet file names (while certainly not encouraged, this should be possible today). Actually the the temp directory serves as a prefix for a wallet name.

So I guess the best way forward is to enforce unicode early in test_runner and remove unneeded checks for unicode. (E.g. L33 that you linked to)

Understood. Should I update this PR to remove that Unicode Check (since it is the only place it is being used)or create a separate issue and PR?
Also, if test dependency not written anywhere in build instructions for dependencies, it should also be added there.

Jup, you can amend the commit and force push the changes, then change the pull request title as needed.

If you also want to adjust the documentation: Feel free to do so at https://github.com/bitcoin/bitcoin/tree/master/test#running-tests-locally

That stdout encoding check does looks broken. It should probably say
"\u2713".encode(sys.stdout.encoding) instead of
"\u2713".encode("utf_8").decode(sys.stdout.encoding).

I don't think the check should be necessarily removed though. While it's true any unix system should be able pass through utf-8 encoded filenames to the filesystem, it's not true that any terminal will happily display utf8 characters.

If you want to do remove or modify the stdout check, I would open a new PR to avoid making the earlier comments in this PR unreadable.

No activity in 7 days for a simple pull request. Closing for now. Let me know when you want to work on this again.