tests: Fix accidental trunction from int to bool #14093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Aug 28, 2018
src/test/scheduler_tests.cpp
Outdated
Member
There was a problem hiding this comment.
please use named arguments for literal primitive types. {/* fDeterministic */ true}
Contributor
Author
There was a problem hiding this comment.
Good point! Fixed! :-)
practicalswift
force-pushed
the
truncation-from-int-to-bool
branch
from
7957b7b to
1cc5897
Compare
Contributor
Author
|
@MarcoFalke Thanks for reviewing. Feedback addressed. Please re-review :-) |
maflcko
pushed a commit
that referenced
this pull request
Aug 29, 2018
1cc5897 tests: Fix accidental trunction from int to bool (practicalswift) Pull request description: Fix accidental trunction from `int` to `bool`. Context: #14086 (comment) Tree-SHA512: 72d209f892e580afa9c295174c206ea5ba764ff9e03613cd9bc57fd0d7118e895ee44d96db90930a29c0b4de7f51dc00101a1b32ba6b46576d34e089ff5482ba
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jun 14, 2021
1cc5897 tests: Fix accidental trunction from int to bool (practicalswift) Pull request description: Fix accidental trunction from `int` to `bool`. Context: bitcoin#14086 (comment) Tree-SHA512: 72d209f892e580afa9c295174c206ea5ba764ff9e03613cd9bc57fd0d7118e895ee44d96db90930a29c0b4de7f51dc00101a1b32ba6b46576d34e089ff5482ba
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix accidental trunction from
inttobool.Context: #14086 (comment)