Disable wallet and address book Qt tests on macOS minimal platform #14011

ryanofsky · 2018-08-20T20:00:40Z

macOS minimal platform is frequently broken, and these are currently failing with Qt 5.11.1.

The tests do pass when run on the full cocoa platform (with test_bitcoin-qt -platform cocoa).

Stack trace from test crash: https://gist.github.com/ryanofsky/3401fb63c52d13d5585e7fc777361f1e

macOS Qt minimal platform is frequently broken, and these are currently failing with Qt 5.11.1. The tests do pass when run on the full cocoa platform (with `test_bitcoin-qt -platform cocoa`).

src/qt/test/addressbooktests.cpp

DrahtBot · 2018-08-20T21:13:05Z

No more conflicts as of last run.

src/qt/test/addressbooktests.cpp

Sjors · 2018-09-07T18:59:37Z

I did make check and src/qt/test/test_bitcoin-qt -platform cocoa, but it's still running WalletTests and AddressBookTests. Maybe I need a different -platform argument?

The test pass for me on macOS 10.13.6 with QT 5.11.1 via Homebrew, with and without this change.

fanquake · 2018-10-09T05:07:23Z

@ryanofsky Could you address any comments/nits here and rebase if needed. I'd like to get this (or something equivalent) merged.

ryanofsky

Updated 391cca5 -> f7a533f (pr/fuqtmac.2 -> pr/fuqtmac.3) just fixing whitespace.

From comments above I guess fanquake could reproduce the test failures, and sjors couldn't, but I think it's best just to skip these tests on the uncommonly used minimal mac platform, rather than try to debug.

src/qt/test/addressbooktests.cpp

fanquake · 2018-10-10T03:29:33Z

tACK f7a533f

make check is now fixed for me.

practicalswift · 2018-10-16T20:24:39Z

src/qt/test/addressbooktests.cpp

+#ifdef Q_OS_MAC
+    if (QApplication::platformName() == "minimal") {
+        // Disable for mac on "minimal" platform to avoid crashes inside the Qt
+        // framework when it tries to look up unimplmented cocoa functions, and


Should be "unimplemented" :-)

ryanofsky · 2018-10-17T17:19:49Z

Updated f7a533f -> a3197c5 (pr/fuqtmac.3 -> pr/fuqtmac.4) with spelling fix.

jonasschnelli · 2018-10-17T18:12:06Z

utACK a3197c5

fanquake · 2018-10-18T01:15:37Z

re-tACK a3197c5

Merged on top of 816fab9 and checked make check -j6.

IlyasRidhuan · 2018-10-19T06:24:04Z

testedAck a3197c5
QWarns correctly outputted to logs

********* Start testing of WalletTests *********
Config: Using QtTest library 5.11.2, Qt 5.11.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 9.1.0 (clang-902.0.39.2) (Apple))
PASS   : WalletTests::initTestCase()
WARNING: WalletTests::walletTests() Skipping WalletTests on mac build with 'minimal' platform set due to Qt bugs. To run AppTests, invoke with 'test_bitcoin-qt -platform cocoa' on mac, or else use a linux or windows build.
   Loc: [qt/test/wallettests.cpp(253)]
PASS   : WalletTests::walletTests()
PASS   : WalletTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 0ms
********* Finished testing of WalletTests *********
********* Start testing of AddressBookTests *********
Config: Using QtTest library 5.11.2, Qt 5.11.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 9.1.0 (clang-902.0.39.2) (Apple))
PASS   : AddressBookTests::initTestCase()
WARNING: AddressBookTests::addressBookTests() Skipping AddressBookTests on mac build with 'minimal' platform set due to Qt bugs. To run AppTests, invoke with 'test_bitcoin-qt -platform cocoa' on mac, or else use a linux or windows build.
   Loc: [qt/test/addressbooktests.cpp(150)]
PASS   : AddressBookTests::addressBookTests()
PASS   : AddressBookTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 0ms
********* Finished testing of AddressBookTests *********
PASS qt/test/test_bitcoin-qt (exit status: 0)

promag · 2018-10-19T14:21:59Z

Can't reproduce the error on macOS 10.14.

src/qt/test/test_bitcoin-qt -platform minimal
********* Start testing of URITests *********
Config: Using QtTest library 5.11.1, Qt 5.11.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 9.1.0 (clang-902.0.39.2) (Apple))
...

ryanofsky · 2018-10-19T15:16:17Z

I think this is ready for merge. It is platform specific and has tested acks from fanquake #14011 (comment) #14011 (comment) and IlyasRidhuan #14011 (comment) and an untested ACK from jonasschnelli #14011 (comment).

Sjors and promag have reported in #14011 (comment) and #14011 (comment) that they actually see tests passing without this change, so the issue does seem be a little unpredictable. But this is a good, safe fix for #14349, and also a prerequisite for #11625, which expands qt test coverage and exposes more problems with the qt mac minimal platform.

promag · 2018-10-19T15:27:26Z

utACK a3197c5, code change LGTM.

jamesob · 2018-10-19T17:59:39Z

utACK a3197c5

Code changes are confined to tests and look good to me.

…al platform a3197c5 Disable wallet and address book Qt tests on macOS minimal platform (Russell Yanofsky) Pull request description: macOS minimal platform is frequently broken, and these are currently failing with Qt 5.11.1. The tests do pass when run on the full cocoa platform (with `test_bitcoin-qt -platform cocoa`). Stack trace from test crash: https://gist.github.com/ryanofsky/3401fb63c52d13d5585e7fc777361f1e Tree-SHA512: a05644ef15d75ea7d7f85ea804c6a5fe78e4e7358b189cbab639d9f7dc46163a35f77f7a2b4ae2fd6be5b9fb22898386b4d88069d5ee8d5fdbd995157c6f0846

macOS Qt minimal platform is frequently broken, and these are currently failing with Qt 5.11.1. The tests do pass when run on the full cocoa platform (with `test_bitcoin-qt -platform cocoa`). Github-Pull: bitcoin#14011 Rebased-From: a3197c5

…14011

…S minimal platform a3197c5 Disable wallet and address book Qt tests on macOS minimal platform (Russell Yanofsky) Pull request description: macOS minimal platform is frequently broken, and these are currently failing with Qt 5.11.1. The tests do pass when run on the full cocoa platform (with `test_bitcoin-qt -platform cocoa`). Stack trace from test crash: https://gist.github.com/ryanofsky/3401fb63c52d13d5585e7fc777361f1e Tree-SHA512: a05644ef15d75ea7d7f85ea804c6a5fe78e4e7358b189cbab639d9f7dc46163a35f77f7a2b4ae2fd6be5b9fb22898386b4d88069d5ee8d5fdbd995157c6f0846

Disable wallet and address book Qt tests on macOS minimal platform

a3197c5

macOS Qt minimal platform is frequently broken, and these are currently failing with Qt 5.11.1. The tests do pass when run on the full cocoa platform (with `test_bitcoin-qt -platform cocoa`).

ryanofsky mentioned this pull request Aug 20, 2018

Add BitcoinApplication & RPCConsole tests #11625

Merged

ryanofsky force-pushed the pr/fuqtmac branch from 3bb80bb to 391cca5 Compare August 20, 2018 20:26

Empact reviewed Aug 20, 2018

View reviewed changes

src/qt/test/addressbooktests.cpp Show resolved Hide resolved

fanquake added macOS Tests labels Aug 20, 2018

promag reviewed Aug 20, 2018

View reviewed changes

src/qt/test/addressbooktests.cpp Show resolved Hide resolved

DrahtBot mentioned this pull request Sep 27, 2018

Multiprocess bitcoin #10102

Draft

ryanofsky force-pushed the pr/fuqtmac branch from 391cca5 to f7a533f Compare September 27, 2018 21:19

fanquake mentioned this pull request Oct 9, 2018

tests: Dry run bench_bitcoin as part "make check" to allow for quick identification of assertion/sanitizer failures in benchmarking code #14092

Merged

fanquake mentioned this pull request Oct 9, 2018

mac: make check failure on macOS 10.14 #14349

Closed

ryanofsky commented Oct 9, 2018

View reviewed changes

src/qt/test/addressbooktests.cpp Show resolved Hide resolved

src/qt/test/addressbooktests.cpp Show resolved Hide resolved

practicalswift reviewed Oct 16, 2018

View reviewed changes

ryanofsky force-pushed the pr/fuqtmac branch from f7a533f to a3197c5 Compare October 17, 2018 17:19

fanquake mentioned this pull request Oct 20, 2018

Problem upgrading to 0.17.0 on macOS High Sierra 10.13.6 #14414

Closed

sipa merged commit a3197c5 into bitcoin:master Oct 20, 2018

fanquake mentioned this pull request Oct 20, 2018

qa: Revert "Make qt wallet test compatible with qt4" #14527

Merged

fanquake mentioned this pull request Oct 24, 2018

[0.17] Backports #14328

Merged

brentkearney mentioned this pull request Feb 25, 2019

make check failure on x64 with MacOS 10.14.3, qt stable 5.12.1. #15480

Closed

Earlz added a commit to qtumproject/qtum-x86 that referenced this pull request Apr 24, 2019

Disable newblock validity test for now, and merge in bitcoin/bitcoin#…

70e26e0

…14011

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Disable wallet and address book Qt tests on macOS minimal platform #14011

Disable wallet and address book Qt tests on macOS minimal platform #14011

Uh oh!

Conversation

ryanofsky commented Aug 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

DrahtBot commented Aug 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Sjors commented Sep 7, 2018

Uh oh!

fanquake commented Oct 9, 2018

Uh oh!

ryanofsky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fanquake commented Oct 10, 2018

Uh oh!

practicalswift Oct 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ryanofsky commented Oct 17, 2018

Uh oh!

jonasschnelli commented Oct 17, 2018

Uh oh!

fanquake commented Oct 18, 2018

Uh oh!

IlyasRidhuan commented Oct 19, 2018

Uh oh!

promag commented Oct 19, 2018

Uh oh!

ryanofsky commented Oct 19, 2018

Uh oh!

promag commented Oct 19, 2018

Uh oh!

jamesob commented Oct 19, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

ryanofsky commented Aug 20, 2018 •

edited

Loading

DrahtBot commented Aug 20, 2018 •

edited

Loading

practicalswift Oct 16, 2018 •

edited

Loading