Additional utility RPCs for PSBT #13932

achow101 · 2018-08-09T21:55:36Z

This PR adds 3 new utility RPCs for interacting with PSBTs.

utxoupdatepsbt updates a PSBT with UTXO information from the node. It only works with witness UTXOs because full transactions (as would be needed for non-witness UTXOs) are not available unless txindex is enabled.

joinpsbts joins the inputs from multiple distinct PSBTs into one PSBT. e.g. if PSBT 1 has inputs 1 and 2, and PSBT 2 has inputs 3 and 4, joinpsbts would create a new PSBT with inputs 1, 2, 3, and 4.

analyzepsbt analyzes a PSBT and determines the current state of it and all of its inputs, and the next step that needs to be done.

DrahtBot · 2018-08-09T22:37:01Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#15404 ([test] Remove -txindex to start nodes by amitiuttarwar)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

gmaxwell · 2018-08-10T05:53:56Z

It only works with witness UTXOs because full transactions (as would be needed for non-witness UTXOs) are not available unless txindex is enabled.

It doesn't look in the wallet?

sipa · 2018-08-10T06:07:08Z

@gmaxwell walletprocesspsbt already exists for that. This is a node RPC that works without a wallet.

achow101 · 2018-08-14T20:48:49Z

Rebased

achow101 · 2018-08-28T21:53:42Z

Rebased

promag · 2018-08-28T23:19:40Z

src/rpc/rawtransaction.cpp

Could reduce indentation?

promag · 2018-08-28T23:29:53Z

src/rpc/rawtransaction.cpp

Could be more informative?

What else could be said?

Like the conflicting input index?

promag · 2018-08-28T23:30:27Z

src/rpc/rawtransaction.cpp

Should allow duplicate outputs? Or should sum values into one output?

Duplicate outputs should be allowed. The idea is that there are two distinct transactions with separate inputs and outputs. They are just being combined into one transaction. Thus you can have duplicate outputs as outputs are still unique. However the inputs must be enforced to be unique.

@achow101 could you ack/nack on #12419, esp @meshcollider #12419 (comment)

promag · 2018-08-28T23:36:08Z

src/rpc/rawtransaction.cpp

So this is necessary because the first is a copy and the remaining psbt inputs are cleared because of AddInput. Maybe remove this "optimization" and merge all psbts to an empty psbt?

I don't see how that is better.

It would be less code, and less complexity, which I would say is always better, absent a reason to write more code. Why write more code?

(Also, this is copied from combinepsbt, where it is easiest to treat the first tx specially, because we need something to compare all the others to, to make sure the underlying transaction is the same. That restriction doesn't exist here, so the need for the extra step is gone.)

promag · 2018-08-28T23:48:17Z

src/rpc/rawtransaction.cpp

Should force txs.size() > 1?

practicalswift · 2018-09-05T07:11:16Z

src/rpc/rawtransaction.cpp

The scope of size could be reduced?

achow101 · 2018-09-13T23:51:54Z

Rebased

practicalswift · 2018-10-02T05:14:10Z

test/functional/rpc_psbt.py


 from test_framework.test_framework import BitcoinTestFramework
 from test_framework.util import assert_equal, assert_raises_rpc_error, find_output
+from decimal import Decimal


Nit: Sort imports :-)

Adds a joinpsbts RPC which combines multiple distinct PSBTs into one PSBT.

When signing an input, figure out what was requested for but was unable to be found and store it in a SignatureData. Return this information in SignPSBTInput.

laanwj · 2019-02-16T19:44:26Z

re-utACK 540729e

540729e Implement analyzepsbt RPC and tests (Andrew Chow) 77542cf Move PSBT UTXO fetching to a separate method (Andrew Chow) cb40b3a Figure out what is missing during signing (Andrew Chow) 08f749c Implement joinpsbts RPC and tests (Andrew Chow) 7344a7b Implement utxoupdatepsbt RPC and tests (Andrew Chow) Pull request description: This PR adds 3 new utility RPCs for interacting with PSBTs. `utxoupdatepsbt` updates a PSBT with UTXO information from the node. It only works with witness UTXOs because full transactions (as would be needed for non-witness UTXOs) are not available unless txindex is enabled. `joinpsbts` joins the inputs from multiple distinct PSBTs into one PSBT. e.g. if PSBT 1 has inputs 1 and 2, and PSBT 2 has inputs 3 and 4, `joinpsbts` would create a new PSBT with inputs 1, 2, 3, and 4. `analyzepsbt` analyzes a PSBT and determines the current state of it and all of its inputs, and the next step that needs to be done. Tree-SHA512: 3c1fa302201abca76a8901d0c2be7b4ccbce334d989533c215f8b3e50e22f2f018ce6209544b26789f58f5980a253c0655111e1e20d47d5656e0414c64891a5c

Summary: bitcoin/bitcoin@7344a7b --- This is a partial backport of Core [[bitcoin/bitcoin#13932 | PR13932]] Test Plan: ninja check test_runner.py rpc_psbt Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6043

Summary: Adds a joinpsbts RPC which combines multiple distinct PSBTs into one PSBT. bitcoin/bitcoin@08f749c --- Depends on D6043 This is a partial backport of Core [[bitcoin/bitcoin#13932 | PR13932]] plus a test case Test Plan: ninja check test_runner.py rpc_psbt Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6044

Summary: bitcoin/bitcoin@77542cf --- Depends on D6044 This is a partial backport of Core [[bitcoin/bitcoin#13932 | PR13932]] Test Plan: unfortunately no tests are included with this commit Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6045

Summary: When signing an input, figure out what was requested for but was unable to be found and store it in a SignatureData. Return this information in SignPSBTInput. bitcoin/bitcoin@cb40b3a --- Depends on D6045 This is a partial backport of Core [[bitcoin/bitcoin#13932 | PR13932]] Test Plan: ninja check check-functional Reviewers: #bitcoin_abc, deadalnix, nakihito Reviewed By: #bitcoin_abc, deadalnix, nakihito Subscribers: nakihito, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6046

Summary: bitcoin/bitcoin@540729e --- This completes the backport of Core [[bitcoin/bitcoin#13932 | PR13932]] Test Plan: cmake .. -GNinja -DENABLE_WERROR=ON ninja check-all Reviewers: #bitcoin_abc, nakihito, deadalnix Reviewed By: #bitcoin_abc, nakihito, deadalnix Subscribers: nakihito Differential Revision: https://reviews.bitcoinabc.org/D6058

merge bitcoin#16117, bitcoin#18358, bitcoin#17383, bitcoin#21052, bitcoin#14424, bitcoin#15159, bitcoin#14689, bitcoin#14978, partial bitcoin#16908, bitcoin#14978, bitcoin#13932: Auxillary Backports

This was referenced Aug 9, 2018

Additional safety checks in PSBT signer #13917

Merged

PSBT key path cleanups #13723

Merged

maflcko added RPC/REST/ZMQ Feature labels Aug 10, 2018

maflcko added this to the 0.18.0 milestone Aug 10, 2018

DrahtBot mentioned this pull request Aug 12, 2018

Refactoring CRPCCommand with enum category #13945

Closed

DrahtBot added the Needs rebase label Aug 14, 2018

achow101 force-pushed the psbt-util-rpcs branch from 66bf5c1 to ff443cf Compare August 14, 2018 20:48

DrahtBot removed the Needs rebase label Aug 14, 2018

DrahtBot mentioned this pull request Aug 20, 2018

Preserve a format of RPC command definitions #14008

Merged

DrahtBot added the Needs rebase label Aug 28, 2018

achow101 force-pushed the psbt-util-rpcs branch 2 times, most recently from eeafff2 to f29d03c Compare August 28, 2018 22:22

DrahtBot removed the Needs rebase label Aug 28, 2018

promag reviewed Aug 28, 2018

View reviewed changes

practicalswift reviewed Sep 5, 2018

View reviewed changes

DrahtBot added the Needs rebase label Sep 10, 2018

achow101 force-pushed the psbt-util-rpcs branch from f29d03c to 9004ce4 Compare September 13, 2018 23:51

DrahtBot removed the Needs rebase label Sep 13, 2018

DrahtBot mentioned this pull request Sep 22, 2018

[psbt] Convert non-witness UTXOs to witness if witness sig created #14197

Merged

practicalswift reviewed Oct 2, 2018

View reviewed changes

practicalswift mentioned this pull request Oct 22, 2018

Enable flake8 rule E225 which checks for missing whitespace around op… #14534

Closed

This was referenced Oct 23, 2018

test: Add linter to make sure single parameter constructors are marked explicit #14505

Merged

Refactor PSBT signing logic to enforce invariant and fix signing bug #14588

Merged

achow101 added 4 commits February 16, 2019 00:04

Implement utxoupdatepsbt RPC and tests

7344a7b

Implement joinpsbts RPC and tests

08f749c

Adds a joinpsbts RPC which combines multiple distinct PSBTs into one PSBT.

Figure out what is missing during signing

cb40b3a

When signing an input, figure out what was requested for but was unable to be found and store it in a SignatureData. Return this information in SignPSBTInput.

Move PSBT UTXO fetching to a separate method

77542cf

achow101 force-pushed the psbt-util-rpcs branch 2 times, most recently from 310b395 to 43bbc2c Compare February 16, 2019 05:16

Implement analyzepsbt RPC and tests

540729e

achow101 force-pushed the psbt-util-rpcs branch from 43bbc2c to 540729e Compare February 16, 2019 16:51

laanwj merged commit 540729e into bitcoin:master Feb 16, 2019

kwvg added a commit to kwvg/dash that referenced this pull request Aug 5, 2021

partial bitcoin#13932: Additional utility RPCs for PSBT

a9a2d0d

kwvg added a commit to kwvg/dash that referenced this pull request Aug 9, 2021

partial bitcoin#13932: Additional utility RPCs for PSBT

419bcd3

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

Additional utility RPCs for PSBT #13932

Additional utility RPCs for PSBT #13932

Uh oh!

Conversation

achow101 commented Aug 9, 2018

Uh oh!

DrahtBot commented Aug 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

gmaxwell commented Aug 10, 2018

Uh oh!

sipa commented Aug 10, 2018

Uh oh!

achow101 commented Aug 14, 2018

Uh oh!

achow101 commented Aug 28, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

achow101 commented Sep 13, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laanwj commented Feb 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

DrahtBot commented Aug 9, 2018 •

edited

Loading

laanwj commented Feb 16, 2019 •

edited

Loading