utils: Convert Windows args to utf-8 string #13883

ken2812221 · 2018-08-05T17:40:15Z

Create a new class WinCmdLineArgs when building for Windows. It converts all command line arguments to utf8 string.

donaloconnor · 2018-08-05T18:32:19Z

utACK f059e7a

DrahtBot · 2018-08-05T18:58:35Z

Reviewers, this pull request conflicts with the following ones:

-masterdatadir for datadir bootstrapping #13746 (-masterdatadir for datadir bootstrapping by kallewoof)
Multiprocess bitcoin #10102 ([experimental] Multiprocess bitcoin by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

alexeyneu · 2018-08-13T11:04:54Z

no-bowler
https://imageshack.com/a/img922/8836/nesafY.jpg

	std::wstring h;
	h=GetCommandLineW();

	std::wcout << h;

it's for wwinmain
UPD:
it's smth else here .
works only after setlocale(LC_ALL, "Portuguese_Portugal.1252"); with main/wmain no matter
(?)
upd2:

_setmode(_fileno(stdout), _O_U16TEXT);
std::wcout << L"curaçao";

seems to be only way. Will be handy when verbose log dubbed to stdout .not sure if btc wallet has this option but monero has smth like that

practicalswift · 2018-09-11T07:29:21Z

src/bitcoin-cli.cpp

src/bitcoin-cli.cpp:18:1: warning: #includes are not sorted properly [llvm-include-order]

maflcko · 2018-09-11T13:30:49Z

1e23b1cba1645b50570e1b4ca4f2da03e000f732 is adding a binary file. Is that wanted?

ken2812221 · 2018-09-11T13:35:42Z

@MarcoFalke Sorry, forgot to delete that

practicalswift · 2018-09-13T20:28:34Z

src/bitcoin-cli.cpp

Minor nit:

2018-09-13 21:33:38 clang-tidy(pr=13883): src/bitcoin-cli.cpp:18:1: warning: #includes are not sorted properly [llvm-include-order]

Would you prefer to put tuple after stdio.h? I think we should seperate C and C++ headers.

I don't think we separate C and C++ headers elsewhere, but please sort them.

practicalswift · 2018-09-14T16:07:20Z

src/util.cpp

2018-09-13 21:33:38 clang-tidy(pr=13883): src/util.cpp:1290:2: warning: namespace 'util' not terminated with a closing comment [google-readability-namespace-comments]

NicolasDorier · 2018-09-30T05:35:18Z

Can you add a python test on this? You can probably highjack https://github.com/bitcoin/bitcoin/blob/78dae8caccd82cfbfd76557f1fb7d7557c7b5edb/test/functional/feature_uacomment.py by trying to set a chinese char.

maflcko · 2018-10-01T01:12:41Z

Concept ACK 380c843 (Only checked that this should only affect Windows. Didn't review nor checked that the tests fail without this fix on windows.)

NicolasDorier · 2018-10-01T08:18:20Z

tACK 380c843 . The test is breaking without the fix.

380c843 utils: Convert Windows args to utf-8 string (Chun Kuan Lee) Pull request description: Create a new class `WinCmdLineArgs` when building for Windows. It converts all command line arguments to utf8 string. Tree-SHA512: f098520fd123a8a452bc84a55dc8c0b88f0c475410efe57f2ccc393f86c396eed59ea1575ddc1b920323792e390fdb092061d80cdcd9b682f0ac79a22a22ff82

Backports bitcoin#13883 Create a new class WinCmdLineArgs when building for Windows. It converts all command line arguments to utf8 string.

63e0be6 [Remove] By-pass logprint-scanner restriction. (furszy) 280ced3 utils: Fix broken Windows filelock (Chun Kuan Lee) be89860 utils: Convert Windows args to utf-8 string (Chun Kuan Lee) e8cfa6e Call unicode API on Windows (Chun Kuan Lee) 1a02a8a tests: Add test case for std::ios_base::ate (Chun Kuan Lee) 2e57cd4 Move boost/std fstream to fsbridge (furszy) 9d8bcd4 utils: Add fsbridge fstream function wrapper (Chun Kuan Lee) d59d48d utils: Convert fs error messages from multibyte to utf-8 (ken2812221) 9ef58cc Logging: use "fmterr" variable name for errors instead of general "e" that can be used by any other function. (furszy) dd94241 utils: Use _wfopen and _wreopen on Windows (Chun Kuan Lee) 3993641 add unicode compatible file_lock for Windows (Chun Kuan Lee) 48349f8 Provide relevant error message if datadir is not writable. (murrayn) Pull request description: As the software is currently using the ANSI encoding on Windows, the user's language settings could affect the proper functioning of the node/wallet, to the point of not be able to open some non-ASCII name files and directories. This solves the Windows encoding issues, completing the entire bitcoin#13869 work path (and some other required backports). Enabling for example users that use non-english characters in directories and file names to be accepted. Backported PRs: * bitcoin#12422. * bitcoin#12630. * bitcoin#13862. * bitcoin#13866. * bitcoin#13877. * bitcoin#13878. * bitcoin#13883. * bitcoin#13884. * bitcoin#13886. * bitcoin#13888. * bitcoin#14192. * bitcoin#13734. * bitcoin#14426. This is built on top of other two PRs that i have open #2423 and #2369. Solves old issues #940 and #2163. TODO: * Backport `assert_start_raises_init_error` and `ErrorMatch` in TestNode` (bitcoin#12718) ACKs for top commit: Fuzzbawls: ACK 63e0be6 random-zebra: ACK 63e0be6 and merging... Tree-SHA512: cb1f7c23abb5b7b3af50bba18652cc2cad93fd7c2fca9c16ffd3fee34c4c152a3b666dfa87fe6b44c430064dcdee4367144dcb4a41203c91b0173b805bdb3d7d

ken2812221 mentioned this pull request Aug 5, 2018

Filename and command line encoding issue on Windows #13869

Closed

12 tasks

This was referenced Aug 5, 2018

-masterdatadir for datadir bootstrapping #13746

Closed

bitcoin-cli: -stdinwalletpassphrase and non-echo stdin passwords #13716

Merged

laanwj added the Windows label Aug 6, 2018

ken2812221 mentioned this pull request Aug 12, 2018

Call unicode API on Windows #13888

Merged

DrahtBot mentioned this pull request Aug 26, 2018

Use std::unordered_set instead of set in blockfilter interface #14074

Merged

practicalswift reviewed Sep 11, 2018

View reviewed changes

src/bitcoin-cli.cpp Outdated

Copy link

Contributor

practicalswift Sep 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/bitcoin-cli.cpp:18:1: warning: #includes are not sorted properly [llvm-include-order]

practicalswift reviewed Sep 13, 2018

View reviewed changes

practicalswift reviewed Sep 14, 2018

View reviewed changes

DrahtBot mentioned this pull request Sep 15, 2018

Test for Windows encoding issue #13787

Merged

This was referenced Sep 27, 2018

appveyor: script improvement #14241

Merged

Multiprocess bitcoin #10102

Draft

ken2812221 changed the title ~~utils: Convert Windows args to utf-8 string~~ [WIP] utils: Convert Windows args to utf-8 string Sep 28, 2018

ken2812221 changed the title ~~[WIP] utils: Convert Windows args to utf-8 string~~ utils: Convert Windows args to utf-8 string Sep 28, 2018

utils: Convert Windows args to utf-8 string

380c843

maflcko added the Utils/log/libs label Oct 1, 2018

maflcko added this to the 0.18.0 milestone Oct 1, 2018

maflcko merged commit 380c843 into bitcoin:master Oct 8, 2018

ken2812221 deleted the windows-command-line-args branch October 8, 2018 05:08

ken2812221 mentioned this pull request Oct 8, 2018

[Tools] bitcoin-wallet - a tool for creating and managing wallets offline #13926

Merged

Bushstar mentioned this pull request Oct 11, 2018

Updates from bitcoin/master FeatherCoin/Feathercoin#366

Merged

Warrows added a commit to Warrows/PIVX that referenced this pull request Oct 14, 2019

[Utils] Convert Windows args to utf-8 string

5564148

Backports bitcoin#13883 Create a new class WinCmdLineArgs when building for Windows. It converts all command line arguments to utf8 string.

Warrows added a commit to Warrows/PIVX that referenced this pull request Nov 23, 2019

[Utils] Convert Windows args to utf-8 string

4bdace7

Backports bitcoin#13883 Create a new class WinCmdLineArgs when building for Windows. It converts all command line arguments to utf8 string.

furszy mentioned this pull request Jun 24, 2021

Solve filename and command line encoding issues on Windows PIVX-Project/PIVX#2449

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

utils: Convert Windows args to utf-8 string #13883

utils: Convert Windows args to utf-8 string #13883

Uh oh!

Conversation

ken2812221 commented Aug 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

donaloconnor commented Aug 5, 2018

Uh oh!

DrahtBot commented Aug 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexeyneu commented Aug 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

practicalswift Sep 11, 2018

Choose a reason for hiding this comment

Uh oh!

maflcko commented Sep 11, 2018

Uh oh!

ken2812221 commented Sep 11, 2018

Uh oh!

practicalswift Sep 13, 2018

Choose a reason for hiding this comment

Uh oh!

ken2812221 Sep 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

practicalswift Sep 14, 2018

Choose a reason for hiding this comment

Uh oh!

practicalswift Sep 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NicolasDorier commented Sep 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko commented Oct 1, 2018

Uh oh!

NicolasDorier commented Oct 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ken2812221 commented Aug 5, 2018 •

edited

Loading

DrahtBot commented Aug 5, 2018 •

edited

Loading

alexeyneu commented Aug 13, 2018 •

edited

Loading

ken2812221 Sep 14, 2018 •

edited

Loading

practicalswift Sep 14, 2018 •

edited

Loading

NicolasDorier commented Sep 30, 2018 •

edited

Loading

NicolasDorier commented Oct 1, 2018 •

edited

Loading