Fix osslsigncode compile issue in gitian-build #13782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK 39126a3b053372e440e9699bed41c3f53bf632fd |
1 similar comment
Contributor
|
utACK 39126a3b053372e440e9699bed41c3f53bf632fd |
Member
|
utACK |
Contributor
Author
|
@laanwj Added |
maflcko
pushed a commit
that referenced
this pull request
Jul 30, 2018
284f424 Fix osslsigncode compile issue in gitian-build (Chun Kuan Lee) Pull request description: Install libssl1.0-dev that is compatible with osslsigncode. Fixes #13762 Verifed that this gitian descriptor file can sign 0.16.2rc2. Tree-SHA512: 3029b86e77567a4e033b5ad95826e60df12a0486ac3c4afcac48218f5c76ba49e7f1c1307ce93ffc465ca2f24e12c401e4542929263688e4bd6521aeca3ff73b
|
@MarcoFalke @laanwj just as a heads up for the codesigner, compiling osslsigncode with curl (needed for detached-sig-create.sh) creates an in compatibility between curl which requires libssl-dev and libssl1.0-dev. Therefore that compilation of osslsigncode needs to be performed on ubuntu 16.04. |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 29, 2020
284f424 Fix osslsigncode compile issue in gitian-build (Chun Kuan Lee) Pull request description: Install libssl1.0-dev that is compatible with osslsigncode. Fixes bitcoin#13762 Verifed that this gitian descriptor file can sign 0.16.2rc2. Tree-SHA512: 3029b86e77567a4e033b5ad95826e60df12a0486ac3c4afcac48218f5c76ba49e7f1c1307ce93ffc465ca2f24e12c401e4542929263688e4bd6521aeca3ff73b
xdustinface
added a commit
to xdustinface/dash
that referenced
this pull request
Dec 21, 2020
We use osslsigncode 2.0 already due to dashpay#3258 so this commit reverts backport of bitcoin#13782 (dashpay@619f7fb)
PastaPastaPasta
pushed a commit
to dashpay/dash
that referenced
this pull request
Dec 27, 2020
…-build" We use osslsigncode 2.0 already due to #3258 so this commit reverts backport of bitcoin#13782 (619f7fb)
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
Signed-off-by: pasta <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install libssl1.0-dev that is compatible with osslsigncode.
Fixes #13762
Verifed that this gitian descriptor file can sign 0.16.2rc2.