[contrib] Support ARM and RISC-V symbol check #13724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
|
Thanks for adding this! |
Member
|
utACK 8f62ece7c1dddc4f69141d884b7c1863776c4fa7 (though as it is dependent on #13665, this should only go in after the |
Contributor
Author
|
#13665 is not ready to merge since it would export a lot of symbols. |
Member
|
Have you run the symbol check after cross compilation? It seems to fail for me: |
Contributor
Author
|
@MarcoFalke Fixed. Sorry about not testing before I commited. I've tested 85ec33a35dfec2cc3b2e0decb5e184650caecdef (master + 60976f2) that can successfully do gitian build. |
Member
|
Needs rebase after #13665 |
Contributor
Author
|
Need to skip RISC-V for now, the linker would export so many symbols. |
Contributor
|
Gitian builds for commit 4732fa1 (master):
Gitian builds for commit 73a989af091d816b5029706b7124fd74d7a7f9b2 (master and this pull):
|
Member
FWIW checking the imports (against symbol versions) is much more important than checking the exports, as that's what prevents binary incompatibilities. |
Member
|
utACK c516c3a |
Member
|
Hmm, didn't see this sooner. FWIW, I have another alternative to this we can evaluate. |
This was referenced Aug 26, 2018
Member
|
I'm going ahead and merging this, @luke-jr please rebase your stuff on top. |
laanwj
added a commit
that referenced
this pull request
Aug 31, 2018
c516c3a [contrib] Support ARM and RISC-V symbol check (Chun Kuan Lee) Pull request description: Solve the TODO in the gitian-descripter Tree-SHA512: 8115e2958af3dde43d9d9d05f0b1b1b93b1c2aa513e771a3e4e1342a5d78af2b0e40c0bbb7e9a0d15954897317e6f5a0d80996239af3b376d5ddd527f73428ae
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jul 2, 2021
c516c3a [contrib] Support ARM and RISC-V symbol check (Chun Kuan Lee) Pull request description: Solve the TODO in the gitian-descripter Tree-SHA512: 8115e2958af3dde43d9d9d05f0b1b1b93b1c2aa513e771a3e4e1342a5d78af2b0e40c0bbb7e9a0d15954897317e6f5a0d80996239af3b376d5ddd527f73428ae # Conflicts: # contrib/devtools/symbol-check.py # contrib/gitian-descriptors/gitian-linux.yml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve the TODO in the gitian-descripter