wallet: Add GetBalances to calculate all balances #13637
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
A wallet with 20k transactions, this improves around 30% of the execution time. |
maflcko
reviewed
Jul 11, 2018
src/wallet/wallet.cpp
Outdated
Contributor
Author
There was a problem hiding this comment.
BTW this is another experiment where many computations are deduped per wallet tx. Still WIP.
maflcko
reviewed
Jul 11, 2018
src/wallet/wallet.h
Outdated
Member
There was a problem hiding this comment.
Could return WalletBalances instead to avoid having to pass a ton of args?
Contributor
Author
There was a problem hiding this comment.
Not sure, wouldn't it add cyclic dependency?
Contributor
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Merged
promag
force-pushed
the
2018-06-wallet-getbalance
branch
from
96fffac to
74c8ccf
Compare
The new method `CWallet::GetBalances` computes all balances in one iteration. It also avoids repetitive lock/unlock for each wallet transaction.
promag
force-pushed
the
2018-06-wallet-getbalance
branch
from
74c8ccf to
c32f356
Compare
Contributor
| Needs rebase |
martinpgaunt
approved these changes
Jul 18, 2018
Contributor
Author
|
This introduces duplicate code which. Closing for now because I think a different refactor might make sense. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new method
CWallet::GetBalancescomputes all balances in one iteration.It also avoids repetitive lock/unlock for each wallet transaction.