Skip to content

Conversation

@Diapolo
Copy link

@Diapolo Diapolo commented May 19, 2012

Gavin suggested to remove strncasecmp() + strnicmp() usage instead of fixing strnicmp() to _strnicmp() and this is what this pull does.

  • remove strncasecmp() + strnicmp() calls and replace that code via boost::algorithm::istarts_with()
  • do not call ipcInit() on Mac and Windows as this is unneeded currently

…st::algorithm::istarts_with() / do not call ipcInit() on Mac and Windows as this is unneeded currently
@gavinandresen
Copy link
Contributor

ACK

@laanwj
Copy link
Member

laanwj commented May 20, 2012

Nice, ACK

@TheBlueMatt
Copy link
Contributor

ACK

sipa added a commit that referenced this pull request May 20, 2012
remove strncasecmp() + strnicmp() calls use boost::algorithm::istarts_with()
@sipa sipa merged commit 6e86c47 into bitcoin:master May 20, 2012
coblee pushed a commit to litecoin-project/litecoin that referenced this pull request Jul 17, 2012
remove strncasecmp() + strnicmp() calls use boost::algorithm::istarts_with()
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request May 6, 2020
594e027 banlist (bugfix): allow CNode::SweepBanned() to run on interval (Philip Kaufmann)
215fcf7 banlist: add more banlist infos to log / add GUI signal (Philip Kaufmann)
4655134 banlist: better handling of banlist in StartNode() (Philip Kaufmann)
f6ec277 banlist: update set dirty to be more fine grained (Philip Kaufmann)

Pull request description:

  Minor updates to how the banlist is handled. ported from bitcoin#7350

ACKs for top commit:
  random-zebra:
    utACK 594e027
  furszy:
    utACK 594e027

Tree-SHA512: a81675ddd48fe30f4978dfd09a7739176ed8dd351eba9d423e04693c5e81b8f266b6343a84b945e341e9235e110b04fe87e4b2a5f304f00689df983d952bd93e
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
@maflcko maflcko removed the CI failed label Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants