Skip to content

doc: Add release notes for -printtoconsole and -debuglogfile changes #13625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Jul 18, 2018
Merged

doc: Add release notes for -printtoconsole and -debuglogfile changes #13625

laanwj merged 1 commit into from
Jul 18, 2018

Conversation

@ghost
Copy link

@ghost ghost commented Jul 10, 2018

This adds release notes relevant to the changes in #13004 and documented in command line help in #13614.

@ghost ghost force-pushed the printtoconsole_release_notes branch from 73cd13b to b29a700 Compare July 10, 2018 19:47
@ghost
Copy link
Author

ghost commented Jul 10, 2018 •
edited by ghost
Loading

I attempted to bring this branch up-to-date with Master to attempt to get the Travis CI build to pass, and followed the instructions for rebasing in CONTRIBUTING.md to squash my two commits down to one, but something went wrong and now many other files are affected that I never touched. I will try to get everything going properly but if any maintainer wants to step in and fix it, please feel free. Only the additional few lines in doc/release-notes.md are my changes.

Everything is rebased properly, I think. Not sure why the Travis CI build is still failing.

@fanquake fanquake added the Docs label Jul 11, 2018
@ghost ghost force-pushed the printtoconsole_release_notes branch from faac03e to 84289b2 Compare July 11, 2018 03:45
@fanquake
Copy link
Member

fanquake commented Jul 11, 2018

@satwo Travis is failing because of the trailing whitespace at the end of the lines you've added. You'll need to remove it.

@ghost
Copy link
Author

ghost commented Jul 11, 2018

@fanquake Thank you! Had a feeling it was something like that, but wasn't sure how to read the lint error.

@ghost ghost force-pushed the printtoconsole_release_notes branch from 060310c to 1a558eb Compare July 11, 2018 18:57
doc: Add release notes for -printtoconsole and -debuglogfile changes
801cb30 
This adds release notes relevant to the changes in #13004 and documented in command line help in #13614
@ghost ghost force-pushed the printtoconsole_release_notes branch from 1a558eb to 801cb30 Compare July 11, 2018 19:39
@fanquake
Copy link
Member

fanquake commented Jul 15, 2018

utACK 801cb30

@laanwj
Copy link
Member

laanwj commented Jul 18, 2018

thank you—utACK 801cb30

@laanwj laanwj merged commit 801cb30 into bitcoin:master Jul 18, 2018
laanwj added a commit that referenced this pull request Jul 18, 2018
@laanwj
Merge #13625: doc: Add release notes for -printtoconsole and -debuglo…
7146672 
…gfile changes

801cb30 doc: Add release notes for -printtoconsole and -debuglogfile changes (Samuel B. Atwood)

Pull request description:

  This adds release notes relevant to the changes in #13004 and documented in command line help in #13614.

Tree-SHA512: ff320415afa9be1ace37ebf0a69ee5a7e6d4167465bc41111be062a556da9b8accfc39553fac610e68521c7ab2095126ace4f012a32f5e9f37cbec39cfa74b04
@ghost ghost deleted the printtoconsole_release_notes branch July 18, 2018 15:53
@Bushstar Bushstar mentioned this pull request Jul 19, 2018
Merged
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fanquake @laanwj