Skip to content

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Jul 8, 2018

This is a rebased version of #13589 with the changes to the 0.16.x release notes removed.

#13004 changed the default behavior for printtoconsole but this has not been reflected in the command line help.

This fixes the description of -printtoconsole to reflect this change, and also provides the user with missing information on how to explicitly disable logging to debug.log.

At present I have made the latter update to two separate places (-printtoconsole and -debuglogfile) because a user looking for information on how to disable logging is probably going to look in the "Debugging/Testing Options" section. Moving -debuglogfile from the "General" options category to the "Debugging/Testing" section could potentially remove the need for this redundancy but may be out of the scope of this PR.

bitcoin#13004 changed the default behavior for printtoconsole but this has not been reflected in the command line help.

This fixes the description of -printtoconsole to reflect this change, and also provides the user with missing information on how to explicitly disable logging to debug.log.

At present I have made the latter update to two separate places (-printtoconsole and -debuglogfile) because a user looking for information on how to disable logging is probably going to look in the "Debugging/Testing Options" section. Moving -debuglogfile from the "General" options category to the "Debugging/Testing" section could potentially remove the need for this redundancy but may be out of the scope of this PR.
@promag
Copy link
Contributor

promag commented Jul 8, 2018

So no release notes of #13004?

@ghost
Copy link

ghost commented Jul 9, 2018

@promag I was going to say the same. I intended to move them to doc/release-notes.md per @laanwj 's suggestion; is there a way I could still do that?

@practicalswift
Copy link
Contributor

ACK 5e362c0

@laanwj laanwj changed the title doc: Update command line help for -printtoconsole and -debuglogfile doc: Update command line help for -printtoconsole and -debuglogfile (satwo) Jul 9, 2018
@laanwj
Copy link
Member

laanwj commented Jul 9, 2018

utACK 5e362c0

@laanwj 's suggestion; is there a way I could still do that?

Yes, at this point I'd recommend to make a new PR—one that does the release notes update only.

@laanwj laanwj merged commit 5e362c0 into bitcoin:master Jul 9, 2018
laanwj added a commit that referenced this pull request Jul 9, 2018
…debuglogfile (satwo)

5e362c0 Fix command line help for -printtoconsole and -debuglogfile (Samuel B. Atwood)

Pull request description:

  This is a rebased version of #13589 with the changes to the 0.16.x release notes removed.

  > #13004 changed the default behavior for printtoconsole but this has not been reflected in the command line help.

  > This fixes the description of -printtoconsole to reflect this change, and also provides the user with missing information on how to explicitly disable logging to debug.log.

  > At present I have made the latter update to two separate places (-printtoconsole and -debuglogfile) because a user looking for information on how to disable logging is probably going to look in the "Debugging/Testing Options" section. Moving -debuglogfile from the "General" options category to the "Debugging/Testing" section could potentially remove the need for this redundancy but may be out of the scope of this PR.

Tree-SHA512: 7461d59a1864039d5a9dfcce765a1169df882f51a4ca50a6066416c0803821cd821be07be534e0bd57f0a22c0b45adb881a93abbe91962bc37d2d228f35ee712
laanwj added a commit that referenced this pull request Jul 18, 2018
…gfile changes

801cb30 doc: Add release notes for -printtoconsole and -debuglogfile changes (Samuel B. Atwood)

Pull request description:

  This adds release notes relevant to the changes in #13004 and documented in command line help in #13614.

Tree-SHA512: ff320415afa9be1ace37ebf0a69ee5a7e6d4167465bc41111be062a556da9b8accfc39553fac610e68521c7ab2095126ace4f012a32f5e9f37cbec39cfa74b04
@fanquake fanquake deleted the satwo_contrib_rebased branch August 7, 2018 04:30
HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Sep 11, 2018
This adds release notes relevant to the changes in bitcoin#13004 and documented in command line help in bitcoin#13614
jfhk pushed a commit to jfhk/bitcoin that referenced this pull request Nov 14, 2018
This adds release notes relevant to the changes in bitcoin#13004 and documented in command line help in bitcoin#13614
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 17, 2020
…e and -debuglogfile (satwo)

5e362c0 Fix command line help for -printtoconsole and -debuglogfile (Samuel B. Atwood)

Pull request description:

  This is a rebased version of bitcoin#13589 with the changes to the 0.16.x release notes removed.

  > bitcoin#13004 changed the default behavior for printtoconsole but this has not been reflected in the command line help.

  > This fixes the description of -printtoconsole to reflect this change, and also provides the user with missing information on how to explicitly disable logging to debug.log.

  > At present I have made the latter update to two separate places (-printtoconsole and -debuglogfile) because a user looking for information on how to disable logging is probably going to look in the "Debugging/Testing Options" section. Moving -debuglogfile from the "General" options category to the "Debugging/Testing" section could potentially remove the need for this redundancy but may be out of the scope of this PR.

Tree-SHA512: 7461d59a1864039d5a9dfcce765a1169df882f51a4ca50a6066416c0803821cd821be07be534e0bd57f0a22c0b45adb881a93abbe91962bc37d2d228f35ee712
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants