Skip to content

Conversation

@ken2812221
Copy link
Contributor

The default CXXFLAGS is -g -O2, this should not appear when enable debug.
fixes #13432

Copy link
Contributor

@murrayn murrayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9882d1f

@achow101
Copy link
Member

utACK 9882d1f

@fanquake fanquake requested a review from theuni June 13, 2018 01:43
@laanwj
Copy link
Member

laanwj commented Jun 13, 2018

utACK 9882d1f

@laanwj laanwj merged commit 9882d1f into bitcoin:master Jun 13, 2018
laanwj added a commit that referenced this pull request Jun 13, 2018
9882d1f Reset default -g -O2 flags when enable debug (Chun Kuan Lee)

Pull request description:

  The default CXXFLAGS is -g -O2, this should not appear when enable debug.
  fixes #13432

Tree-SHA512: 79447f3e1fab9e6cd12f5ca49b3d42187e856e0c159ed01140ea93d6ef1fbb1af3d65b338308566330491052c0177d12abe26796513502ddde31692665a0dbb4
@ken2812221 ken2812221 deleted the debug_cflags branch June 13, 2018 13:59
@theuni
Copy link
Member

theuni commented Jun 13, 2018

post-merge utACK 9882d1f

zkbot added a commit to zcash/zcash that referenced this pull request Jan 30, 2020
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Jun 28, 2021
9882d1f Reset default -g -O2 flags when enable debug (Chun Kuan Lee)

Pull request description:

  The default CXXFLAGS is -g -O2, this should not appear when enable debug.
  fixes bitcoin#13432

Tree-SHA512: 79447f3e1fab9e6cd12f5ca49b3d42187e856e0c159ed01140ea93d6ef1fbb1af3d65b338308566330491052c0177d12abe26796513502ddde31692665a0dbb4
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build: ./configure --enable-debug generates -O2 optimization option which overrides earlier -Og.

6 participants