Prevent shared conf files from failing with different available options in different binaries #13441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
utACK 009f737. |
achow101
force-pushed
the
gargs-disabled-options
branch
from
009f737 to
f6b81b2
Compare
Member
Author
Oh right. Added those. |
kallewoof
reviewed
Jun 12, 2018
Contributor
kallewoof
left a comment
kallewoof
left a comment
There was a problem hiding this comment.
utACK f6b81b23102377e9c4e81c65d1faf54306bd0c73
All these lines makes me want to have a gArgs.AddDisabledArgs("-addresstype", "-changetype", ...) method though (could take a vector or vargs).
achow101
force-pushed
the
gargs-disabled-options
branch
from
f6b81b2 to
abd07b9
Compare
Member
Author
I have added such a method which takes a vector of strings to add as hidden arguments. |
ken2812221
reviewed
Jun 12, 2018
src/init.cpp
Outdated
Options that are not available (but known in the source code) will cause an error if they are specified. Make these options "available" by adding them to the hidden options category to prevent conf files from failing when shared between binaries that have different options available.
achow101
force-pushed
the
gargs-disabled-options
branch
from
abd07b9 to
c2dfbb4
Compare
kallewoof
approved these changes
Jun 12, 2018
Member
|
utACK c2dfbb4 |
maflcko
pushed a commit
that referenced
this pull request
Jun 13, 2018
…vailable options in different binaries c2dfbb4 Add unavailable options to hidden options category (Andrew Chow) Pull request description: From IRC: ``` <ossifrage> FYI, bitcoin-qt from the head I built today won't start if you have "daemon=0" in the config file, so you can't use the same config for either bitcoind or bitcoin-qt <ossifrage> Seems like bitcoin-qt should ignore this option? <provoostenator> ossifrage: probably caused by 13112. Another problem is disablewallet=1 will prevent a launch if you compile bitcoind without wallet. It probably needs to be relaxed slightly. ``` Adds all of the options that are unavailable due to compiling options to the hidden category so that shared config files do not break with the alternative binaries. Tree-SHA512: 1ef43f5f7ad46ecc2865d22ee683ef22831e8f131ec99b732bb36d90381f7964bf64829595e993c2d435823fe4425a20323c8e65307cf2463a9e40b8049ab559
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jun 28, 2021
…erent available options in different binaries c2dfbb4 Add unavailable options to hidden options category (Andrew Chow) Pull request description: From IRC: ``` <ossifrage> FYI, bitcoin-qt from the head I built today won't start if you have "daemon=0" in the config file, so you can't use the same config for either bitcoind or bitcoin-qt <ossifrage> Seems like bitcoin-qt should ignore this option? <provoostenator> ossifrage: probably caused by 13112. Another problem is disablewallet=1 will prevent a launch if you compile bitcoind without wallet. It probably needs to be relaxed slightly. ``` Adds all of the options that are unavailable due to compiling options to the hidden category so that shared config files do not break with the alternative binaries. Tree-SHA512: 1ef43f5f7ad46ecc2865d22ee683ef22831e8f131ec99b732bb36d90381f7964bf64829595e993c2d435823fe4425a20323c8e65307cf2463a9e40b8049ab559
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From IRC:
Adds all of the options that are unavailable due to compiling options to the hidden category so that shared config files do not break with the alternative binaries.