qa: Remove portseed_offset from test runner #13421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK fa6edfe I think making the port range more deterministic is, overall, a good thing. We don't support multiple |
laanwj
added a commit
that referenced
this pull request
Jun 11, 2018
fa6edfe qa: Remove portseed_offset from test runner (MarcoFalke) Pull request description: The portseed_offset is no longer needed in the test runner, since we already kill leftover processes (see #12904). This "fixes" #10869 because we deterministically pick ports starting at 11000 Tree-SHA512: 1ee22e19e02acd3afadc7c6a2b391fd3b5cfcec22c0fe194f3207251e7b1264a04e47d90a3ff8be4aca7d0ec33219a2f5855076acb3565291767939bc2f2fa17
Member
|
Something that might be useful is to do an initial sweep over all the ports that are going to be used, so if something is in the way, there's an early warning/error. |
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jun 28, 2021
fa6edfe qa: Remove portseed_offset from test runner (MarcoFalke) Pull request description: The portseed_offset is no longer needed in the test runner, since we already kill leftover processes (see bitcoin#12904). This "fixes" bitcoin#10869 because we deterministically pick ports starting at 11000 Tree-SHA512: 1ee22e19e02acd3afadc7c6a2b391fd3b5cfcec22c0fe194f3207251e7b1264a04e47d90a3ff8be4aca7d0ec33219a2f5855076acb3565291767939bc2f2fa17
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jul 8, 2021
Summary: PR description: > The portseed_offset is no longer needed in the test runner, since we already kill leftover processes The pseudo-random portseed causes port collisions with other daemons. Core devs had issues with port 11211 (memcached), and we are seeing issues with 21325 (trezord). This backport is a first step in avoiding random failures, by making the ports more deterministic again. We cannot use the number of tests as a unique seed for Bitcoin ABC like Core does, because we run tests in parallel, so use the test number instead. This is a backport of [[bitcoin/bitcoin#13421 | core#13421]] Test Plan: `for i in {1..4}; do ninja check-functional; done` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D9759
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The portseed_offset is no longer needed in the test runner, since we already kill leftover processes (see #12904). This "fixes" #10869 because we deterministically pick ports starting at 11000