Should not be T minus, as this indicate duration to future event. #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… minus) usually indicates a future event.
Contributor
|
ACK, though I'm curious if others want to preserve the old behavior |
Contributor
|
don't care |
Member
|
ACK |
gmaxwell
added a commit
that referenced
this pull request
May 23, 2012
Should not be T minus, as this indicate duration to future event.
coblee
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Jul 17, 2012
Should not be T minus, as this indicate duration to future event.
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
…-args Emit a warning when parsing disabled parameters rather than raise an error
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
May 6, 2020
bd49362 [Refactor] Move zerocoin checks out of main (Fuzzbawls) Pull request description: This is PR is the final part of breaking up bitcoin#1209 into individual narrow-focused PRs. For this one, the original commit had too many merge conflicts, so it was easier/faster for me to just start from a clean slate and re-do the commit. (reference branch is at https://github.com/Fuzzbawls/PIVX/commits/pr-1209) Reference Commit: Fuzzbawls@547ca6c This moves all zerocoin checking methods out of main.cpp/h into two new files in the `consensus` subdir: zerocoin_verify.cpp/h ACKs for top commit: random-zebra: utACK bd49362 furszy: rebase utACK bd49362. Tree-SHA512: 2ea66411d17bd7a6659243540ff060b7613377bff09633a4d743ccd78fe03efa146c93ff05e68f2347e3202ef5d22c14ca336abb35cc0b7007814e490c0517d6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to a positive number, to indicate a past event, and save a few bytes in debug.log!