crypto: cleanup sha256 build #13408
Merged
crypto: cleanup sha256 build #13408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empact
reviewed
Jun 6, 2018
|
|
||
| LIBBITCOIN_CRYPTO= $(LIBBITCOIN_CRYPTO_BASE) | ||
| if ENABLE_SSE41 | ||
| LIBBITCOIN_CRYPTO_SSE41 = crypto/libbitcoin_crypto_sse41.a |
Contributor
There was a problem hiding this comment.
Given this and LIBBITCOIN_CRYPTO_AVX2 aren't referenced elsewhere, they could be inlined.
Member
Author
There was a problem hiding this comment.
Sure, but I'd prefer to stick with our convention of naming everything for easier re-use down the road.
Rather than appending all possible cpu variants to all targets, create a convenience variable that encompasses all.
Member
|
utACK f68049d |
Contributor
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
|
utACK f68049d |
laanwj
added a commit
that referenced
this pull request
Jun 11, 2018
f68049d crypto: cleanup sha256 build (Cory Fields) Pull request description: Requested by @sipa in #13386. Rather than appending all possible cpu variants to all targets, create a convenience variable that encompasses all. Tree-SHA512: 8e9ab2185515672b79bb7925afa4f3fbfe921bfcbe61456833d15457de4feba95290de17514344ce42ee81cc38b252476cd0c29432ac48c737c2225ed515a4bd
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Oct 1, 2019
f68049d crypto: cleanup sha256 build (Cory Fields) Pull request description: Requested by @sipa in bitcoin#13386. Rather than appending all possible cpu variants to all targets, create a convenience variable that encompasses all. Tree-SHA512: 8e9ab2185515672b79bb7925afa4f3fbfe921bfcbe61456833d15457de4feba95290de17514344ce42ee81cc38b252476cd0c29432ac48c737c2225ed515a4bd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by @sipa in #13386.
Rather than appending all possible cpu variants to all targets, create a convenience variable that encompasses all.