cli: Ignore libevent warnings #13394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK 0231ef6 |
Contributor
|
According to the below the default is to log message to stderr, do we want to keep logging the lower-level messages? Edit: here's the current default behavior https://github.com/libevent/libevent/blob/e83443ec67d45447296c2ce320620a07c88e1d32/log.c#L223 |
Member
|
Yes, the messages go to stderr. Which is normally fine, at least they don't mess up the application output! |
Contributor
|
Maybe send them to the |
Member
|
No, bitcoin-cli should definitely not write to any debug log file.
|
Member
|
@promag Can you test this? It's kind of blocked on that. |
Contributor
|
Tested ACK 0231ef6 - it fixes my problem. @theuni how could I test the Before: After |
laanwj
added a commit
that referenced
this pull request
Jun 7, 2018
0231ef6 cli: Ignore libevent warnings (Cory Fields) Pull request description: Should fix rpc tests that fail due to an unclean stderr. Untested as I'm not seeing these warnings. @promag mind seeing if this fixes your problem? Tree-SHA512: fba5ae3f239b515e93e19f9c3eca659eb7fb21f1b1fec25b68285695bfd1ecbdcd9b2235543689aaf97bff85cbb762840f65365a67e791314e9a6b8db2c9e246
Member
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 11, 2019
Summary: Should fix rpc tests that fail due to an unclean stderr. Backport of Bitcoin Core PR13394 bitcoin/bitcoin#13394 Test Plan: In a **macOS** terminal: ``` ./src/bitcoind -regtest ``` In another **macOS** terminal: ``` ./src/bitcoin-cli -regtest help ``` The following warning should not be seen in stdout/stderr: `[warn] kq_init: detected broken kqueue; not using.: Undefined error: 0` Reviewers: Fabien, #bitcoin_abc, deadalnix Reviewed By: Fabien, #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D4005
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Dec 27, 2019
Summary: Should fix rpc tests that fail due to an unclean stderr. Backport of Bitcoin Core PR13394 bitcoin/bitcoin#13394 Test Plan: In a **macOS** terminal: ``` ./src/bitcoind -regtest ``` In another **macOS** terminal: ``` ./src/bitcoin-cli -regtest help ``` The following warning should not be seen in stdout/stderr: `[warn] kq_init: detected broken kqueue; not using.: Undefined error: 0` Reviewers: Fabien, #bitcoin_abc, deadalnix Reviewed By: Fabien, #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D4005
jonspock
pushed a commit
to devaultcrypto/devault
that referenced
this pull request
Dec 29, 2019
Summary: Should fix rpc tests that fail due to an unclean stderr. Backport of Bitcoin Core PR13394 bitcoin/bitcoin#13394 Test Plan: In a **macOS** terminal: ``` ./src/bitcoind -regtest ``` In another **macOS** terminal: ``` ./src/bitcoin-cli -regtest help ``` The following warning should not be seen in stdout/stderr: `[warn] kq_init: detected broken kqueue; not using.: Undefined error: 0` Reviewers: Fabien, #bitcoin_abc, deadalnix Reviewed By: Fabien, #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D4005
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jun 28, 2021
0231ef6 cli: Ignore libevent warnings (Cory Fields) Pull request description: Should fix rpc tests that fail due to an unclean stderr. Untested as I'm not seeing these warnings. @promag mind seeing if this fixes your problem? Tree-SHA512: fba5ae3f239b515e93e19f9c3eca659eb7fb21f1b1fec25b68285695bfd1ecbdcd9b2235543689aaf97bff85cbb762840f65365a67e791314e9a6b8db2c9e246
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix rpc tests that fail due to an unclean stderr.
Untested as I'm not seeing these warnings. @promag mind seeing if this fixes your problem?