Skip to content

build: Guard against accidental introduction of new Boost dependencies #13385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Jun 5, 2018
Merged

build: Guard against accidental introduction of new Boost dependencies #13385

laanwj merged 1 commit into from
Jun 5, 2018

Conversation

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Jun 3, 2018 •
edited
Loading

Guard against accidental introduction of new Boost dependencies.

Context: #13383 – the usage of boost::lexical_cast was introduced in #11517 from December 2017

@practicalswift practicalswift force-pushed the lint-boost branch 3 times, most recently from b7a4a79 to e4191d3 Compare June 3, 2018 19:35
@laanwj
Copy link
Member

laanwj commented Jun 4, 2018

nothing else to say here

utACK e4191d3419ee4ccda0a611632a859e72c40e7ca4

@practicalswift practicalswift force-pushed the lint-boost branch 2 times, most recently from 72aeb1c to a759694 Compare June 4, 2018 07:42
@practicalswift
Copy link
Contributor Author

practicalswift commented Jun 4, 2018 •
edited
Loading

Updated version: Removed boost/lexical_cast.hpp from EXPECTED_BOOST_INCLUDES now that #13383 has been merged. Added logic that notifies the operator when a previous dependency has been removed, asking for an update of EXPECTED_BOOST_INCLUDES.

@laanwj Please re-review :-)

@promag
Copy link
Contributor

promag commented Jun 4, 2018

Concept ACK.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 4, 2018 •
edited
Loading

Note to reviewers: This pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@practicalswift
Copy link
Contributor Author

practicalswift commented Jun 4, 2018

@DrahtBot I'll simply rebase once one of them is merged :-)

@bitcoin bitcoin deleted a comment from DrahtBot Jun 4, 2018
@maflcko
Copy link
Member

maflcko commented Jun 4, 2018

utACK 81bbd32

@Empact
Copy link
Contributor

Empact commented Jun 5, 2018

Concept ACK

@laanwj laanwj merged commit 81bbd32 into bitcoin:master Jun 5, 2018
laanwj added a commit that referenced this pull request Jun 5, 2018
@laanwj
Merge #13385: build: Guard against accidental introduction of new Boo…
7c7508c 
…st dependencies

81bbd32 build: Guard against accidental introduction of new Boost dependencies (practicalswift)

Pull request description:

  Guard against accidental introduction of new Boost dependencies.

  Context: #13383 – the usage of `boost::lexical_cast` was introduced in #11517 from December 2017

Tree-SHA512: 8d7b667ecf7ea62d84d9d41a71726f1e46c5a411b5a7db475c973ef364cac65609399afda7931e143a27d40c2947ff286e5e98ab263e8f0d225e2ae2c0872935
@Bushstar Bushstar mentioned this pull request Jun 6, 2018
Merged
@Empact Empact mentioned this pull request Jun 6, 2018
Merged
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 2, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#13385: build: Guard against accidental introduction of …
9a9aa3f 
…new Boost dependencies

81bbd32 build: Guard against accidental introduction of new Boost dependencies (practicalswift)

Pull request description:

  Guard against accidental introduction of new Boost dependencies.

  Context: bitcoin#13383 – the usage of `boost::lexical_cast` was introduced in bitcoin#11517 from December 2017

Tree-SHA512: 8d7b667ecf7ea62d84d9d41a71726f1e46c5a411b5a7db475c973ef364cac65609399afda7931e143a27d40c2947ff286e5e98ab263e8f0d225e2ae2c0872935
@str4d str4d mentioned this pull request Oct 27, 2020
Merged
zkbot added a commit to zcash/zcash that referenced this pull request Oct 28, 2020
@zkbot
Auto merge of #4829 - str4d:backport-lints, r=<try>
43ac206 
Backport useful lints from upstream

Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6892
- bitcoin/bitcoin#11151
- bitcoin/bitcoin#11300
- bitcoin/bitcoin@96d91b7
- bitcoin/bitcoin#12097
- bitcoin/bitcoin#12098
- bitcoin/bitcoin#12442
- bitcoin/bitcoin#12572
- bitcoin/bitcoin#12757
- bitcoin/bitcoin#11878
- bitcoin/bitcoin#12933
- bitcoin/bitcoin#12871
- bitcoin/bitcoin#12972
- bitcoin/bitcoin#13281
- bitcoin/bitcoin#13385
- bitcoin/bitcoin#13041
- bitcoin/bitcoin#13454
- bitcoin/bitcoin#13448
- bitcoin/bitcoin#13510
- bitcoin/bitcoin#13851
- bitcoin/bitcoin#13863
- bitcoin/bitcoin#14115
- bitcoin/bitcoin#14831
- bitcoin/bitcoin#15164
- bitcoin/bitcoin#15170
- bitcoin/bitcoin#15166
- bitcoin/bitcoin#16036
- bitcoin/bitcoin#16768

Several of the lints fail for our current codebase; these will be addressed in a
subsequent PR.
zkbot added a commit to zcash/zcash that referenced this pull request Nov 9, 2020
@zkbot
Auto merge of #4829 - str4d:backport-lints, r=str4d
84a5830 
Backport useful lints from upstream

Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6892
- bitcoin/bitcoin#11151
- bitcoin/bitcoin#11300
- bitcoin/bitcoin@96d91b7
- bitcoin/bitcoin#12097
- bitcoin/bitcoin#12098
- bitcoin/bitcoin#12442
- bitcoin/bitcoin#12572
- bitcoin/bitcoin#12757
- bitcoin/bitcoin#11878
- bitcoin/bitcoin#12933
- bitcoin/bitcoin#12871
- bitcoin/bitcoin#12972
- bitcoin/bitcoin#13281
- bitcoin/bitcoin#13385
- bitcoin/bitcoin#13041
- bitcoin/bitcoin#13454
- bitcoin/bitcoin#13448
- bitcoin/bitcoin#13510
- bitcoin/bitcoin#13851
- bitcoin/bitcoin#13863
- bitcoin/bitcoin#14115
- bitcoin/bitcoin#14831
- bitcoin/bitcoin#15164
- bitcoin/bitcoin#15170
- bitcoin/bitcoin#15166
- bitcoin/bitcoin#16036
- bitcoin/bitcoin#16768
- bitcoin/bitcoin#13494

Several of the lints fail for our current codebase; these will be addressed in a
subsequent PR.
@practicalswift practicalswift deleted the lint-boost branch April 10, 2021 19:34
@Fuzzbawls Fuzzbawls mentioned this pull request Feb 7, 2022
Merged
random-zebra added a commit to PIVX-Project/PIVX that referenced this pull request Feb 9, 2022
@random-zebra
Merge #2740: [Lint] Introduce lint-includes.sh script
0e757ad 
ad5717d Lint: Add lint-includes.sh (Fuzzbawls)
faba3f6 [tests] Use FastRandomContext in scheduler_tests.cpp (practicalswift)
2034bf6 Remove unused boost includes in reverselock_tests.cpp (Fuzzbawls)
3256d16 bench: Use non-throwing ParseDouble() (Fuzzbawls)
3c984d1 Remove duplicate includes (Fuzzbawls)
b54e396 Declare TorReply parsing functions in torcontrol_tests (Fuzzbawls)

Pull request description:

  This brings in the `lint-includes.sh` shell script from upstream (first introduced in bitcoin#11878) to automatically check for duplicate includes and expanded in bitcoin#13301 and bitcoin#13385 to check for the inclusion of `.cpp` files and the introduction of new boost includes, respectively.

  The check for enforcing bracket include syntax (bitcoin#13230) is also included, but currently disabled, as we have yet to systematically switch to that syntax preference.

  Three other upstream PRs are backported here as they are directly related to the removal of some boost dependencies and are very straight forward:
  - bitcoin#10547
  - bitcoin#13291
  - bitcoin#13383

  **NOTE: #2711 removes the dependency on `boost/tuple/tuple.hpp`, so it makes sense to merge that first. submitting this now so the general concept/functionality can be reviewed prior to that PR being merged**

ACKs for top commit:
  furszy:
    good ACK ad5717d
  random-zebra:
    utACK ad5717d and merging...

Tree-SHA512: d9d32d6d5122dac52c9601cda75612d87c4e027c6f196a2382206b227fcfd2bb61d4f72df7cbf5e572d94150ad8ca6db6301bd99b0da647b9627fe342b66873f
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Feb 21, 2022
@laanwj @gades
Merge bitcoin#13385: build: Guard against accidental introduction of …
2dddfca 
…new Boost dependencies

81bbd32 build: Guard against accidental introduction of new Boost dependencies (practicalswift)

Pull request description:

  Guard against accidental introduction of new Boost dependencies.

  Context: bitcoin#13383 – the usage of `boost::lexical_cast` was introduced in bitcoin#11517 from December 2017

Tree-SHA512: 8d7b667ecf7ea62d84d9d41a71726f1e46c5a411b5a7db475c973ef364cac65609399afda7931e143a27d40c2947ff286e5e98ab263e8f0d225e2ae2c0872935
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Scripts and tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@practicalswift @laanwj @promag @DrahtBot @maflcko @Empact @fanquake