refactor: privatize SignatureExtractorChecker [moveonly] #13266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
utACK 61f178b. |
Empact
force-pushed
the
data-from-transaction
branch
from
61f178b to
7815ac1
Compare
Contributor
Author
|
Rebased for #13269 |
Empact
force-pushed
the
data-from-transaction
branch
from
7815ac1 to
8b680d4
Compare
Empact
changed the title
Contributor
Author
Empact
force-pushed
the
data-from-transaction
branch
from
8b680d4 to
1f85582
Compare
Empact
changed the title
sipa
reviewed
Jul 14, 2018
src/script/sign.h
Outdated
Member
There was a problem hiding this comment.
I would prefer to keep SignatureData independent from the data being signed.
Empact
force-pushed
the
data-from-transaction
branch
from
1f85582 to
ef7457d
Compare
Empact
changed the title
Empact
force-pushed
the
data-from-transaction
branch
from
ef7457d to
4012fe1
Compare
Member
|
utACK 4012fe1be85ee00d55951a5bb69bd451159a9ea0 |
Empact
force-pushed
the
data-from-transaction
branch
from
4012fe1 to
a0a0df3
Compare
Contributor
Author
|
Rebased for #13557 |
Member
|
utACK a0a0df379519bef6db33f69ed668d9c251d0dfe7 |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Empact
changed the title
It's only used here in DataFromTransaction
Empact
force-pushed
the
data-from-transaction
branch
from
a0a0df3 to
73aaf4e
Compare
Contributor
Author
|
Rebased. |
Member
|
utACK 73aaf4e |
Contributor
Author
laanwj
changed the title
Member
|
ACK 73aaf4e |
laanwj
added a commit
that referenced
this pull request
Oct 2, 2019
73aaf4e Make SignatureExtractorChecker private to its own file (Ben Woosley) Pull request description: ~If we add a CTxIn constructor to SignatureData, then constructing the SignatureData directly is no more verbose than calling DataFromTransaction, and grants the caller additional flexibiliy in how to provide the CTxIn.~ A simple change to enhance encapsulation. ACKs for top commit: MarcoFalke: utACK 73aaf4e laanwj: ACK 73aaf4e Tree-SHA512: f7eafbce22b0e9917a8487e88d1f5a1061f2a0959ae1a097cbd9c8ea0d774edfb807da56813cb5fb26f6ca98499a0604a8ff024c198a7c8dc755164de66d972a
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 2, 2019
…oveonly] 73aaf4e Make SignatureExtractorChecker private to its own file (Ben Woosley) Pull request description: ~If we add a CTxIn constructor to SignatureData, then constructing the SignatureData directly is no more verbose than calling DataFromTransaction, and grants the caller additional flexibiliy in how to provide the CTxIn.~ A simple change to enhance encapsulation. ACKs for top commit: MarcoFalke: utACK 73aaf4e laanwj: ACK 73aaf4e Tree-SHA512: f7eafbce22b0e9917a8487e88d1f5a1061f2a0959ae1a097cbd9c8ea0d774edfb807da56813cb5fb26f6ca98499a0604a8ff024c198a7c8dc755164de66d972a
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 24, 2020
Summary: It's only used here in sign.cpp in DataFromTransaction(), so this enhances encapsulation. This is a backport of Core [[bitcoin/bitcoin#13266 | PR13266]] Test Plan: `ninja && ninja check` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D8088
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 11, 2021
…oveonly] 73aaf4e Make SignatureExtractorChecker private to its own file (Ben Woosley) Pull request description: ~If we add a CTxIn constructor to SignatureData, then constructing the SignatureData directly is no more verbose than calling DataFromTransaction, and grants the caller additional flexibiliy in how to provide the CTxIn.~ A simple change to enhance encapsulation. ACKs for top commit: MarcoFalke: utACK 73aaf4e laanwj: ACK 73aaf4e Tree-SHA512: f7eafbce22b0e9917a8487e88d1f5a1061f2a0959ae1a097cbd9c8ea0d774edfb807da56813cb5fb26f6ca98499a0604a8ff024c198a7c8dc755164de66d972a
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 15, 2021
…oveonly] 73aaf4e Make SignatureExtractorChecker private to its own file (Ben Woosley) Pull request description: ~If we add a CTxIn constructor to SignatureData, then constructing the SignatureData directly is no more verbose than calling DataFromTransaction, and grants the caller additional flexibiliy in how to provide the CTxIn.~ A simple change to enhance encapsulation. ACKs for top commit: MarcoFalke: utACK 73aaf4e laanwj: ACK 73aaf4e Tree-SHA512: f7eafbce22b0e9917a8487e88d1f5a1061f2a0959ae1a097cbd9c8ea0d774edfb807da56813cb5fb26f6ca98499a0604a8ff024c198a7c8dc755164de66d972a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we add a CTxIn constructor to SignatureData, then constructing theSignatureData directly is no more verbose than calling DataFromTransaction,
and grants the caller additional flexibiliy in how to provide the CTxIn.
A simple change to enhance encapsulation.