Skip to content

doc: Bump to Ubuntu Bionic 18.04 in build-windows.md #13246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
May 24, 2018
Merged

doc: Bump to Ubuntu Bionic 18.04 in build-windows.md #13246

laanwj merged 1 commit into from
May 24, 2018

Conversation

@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented May 16, 2018

Windows starts to provide Ubuntu 18.04 WSL, it can be downloaded from Microsoft Store.

@fanquake fanquake added the Docs label May 16, 2018
@promag
Copy link
Contributor

promag commented May 16, 2018

Concept ACK.

There are more references to 17.10 that could be bumped?

@fanquake
Copy link
Member

fanquake commented May 16, 2018

Concept ACK
This will need a few more updates though. For example Ubuntu and Ubuntu 18.04 are two different items in the Windows Store, so we should link to 18.04 from here.

@maflcko
Copy link
Member

maflcko commented May 16, 2018

I had the impression that we only support windows cross builds for bionic, due to qt 5.9. So might as well remove all previous versions/workarounds?

@ken2812221
Copy link
Contributor Author

ken2812221 commented May 16, 2018

According to @MarcoFalke's comment, removed all other distros except for Ubuntu 18.04. Also changed the Ubuntu 18.04 WSL link according to @fanquake's comment.

@fanquake
Copy link
Member

fanquake commented May 17, 2018

Thanks @ken2812221 . Instructions are looking simpler now. Was going to run through a build but VirtualBox has crashed twice while building depends using 18.04 WSL.. Will ACK once I've got a build finished.

@ken2812221
Copy link
Contributor Author

ken2812221 commented May 17, 2018

Update: Search "Ubuntu 18.04"

@laanwj
Copy link
Member

laanwj commented May 17, 2018

Concept ACK. I like this as it gets rid of a lot of confusing backwards compatibility cruft.

laanwj
laanwj reviewed May 17, 2018
View reviewed changes
doc/build-windows.md Outdated
Copy link
Member

@laanwj laanwj May 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, no more need to install packages from a different version of ubuntu.

laanwj
laanwj reviewed May 17, 2018
View reviewed changes
doc/build-windows.md Outdated
Copy link
Member

@laanwj laanwj May 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this stay this way? Or is this temporarily, until 1804 becomes the default

Copy link
Contributor Author

@ken2812221 ken2812221 May 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, it's a different app in Microsoft Store now.

Copy link
Member

@fanquake fanquake May 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple different Ubuntu "Apps" available in the Windows store, so I think this should be ok for now.

laanwj
laanwj reviewed May 17, 2018
View reviewed changes
doc/build-windows.md Outdated
Copy link
Member

@laanwj laanwj May 17, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add that the steps in this document only apply for 18.04. Only saying that it is recommended is not enough, as it means you'd still have to warn people against using 16.04.

Copy link
Contributor Author

@ken2812221 ken2812221 May 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change recommended to required

@ken2812221
doc: Bump to Ubuntu Bionic 18.04 in build-windows.md
9d4f942 
Windows starts to provide Ubuntu 18.04 WSL, it can be downloaded from Microsoft Store.
@maflcko maflcko mentioned this pull request May 17, 2018
Merged
@fanquake
Copy link
Member

fanquake commented May 23, 2018

TestedACK 9d4f942

This is a good cleanup, less workarounds.

I've done a 64 bit depends build using WSL on a clean Windows 10 VM @ 6916024
wsl

@maflcko
Copy link
Member

maflcko commented May 23, 2018

utACK 9d4f942

@laanwj laanwj merged commit 9d4f942 into bitcoin:master May 24, 2018
laanwj added a commit that referenced this pull request May 24, 2018
@laanwj
Merge #13246: doc: Bump to Ubuntu Bionic 18.04 in build-windows.md
5c41b60 
9d4f942 doc: Bump to Ubuntu Bionic 18.04 in build-windows.md (Chun Kuan Lee)

Pull request description:

  Windows starts to provide Ubuntu 18.04 WSL, it can be downloaded from Microsoft Store.

Tree-SHA512: a96ed03f36894ad867fd88631c1497eac7fc1cdaee8f59f36f34781df0b0f0b352a1bd8f09eba61002534fb7e0fe460006f223e37d61ad888197a36d17b43178
@ken2812221 ken2812221 deleted the patch-2 branch May 24, 2018 08:54
@Bushstar Bushstar mentioned this pull request May 26, 2018
Merged
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request May 28, 2018
@ken2812221 @fanquake
doc: Bump to Ubuntu Bionic 18.04 in build-windows.md
6de7543 
Windows starts to provide Ubuntu 18.04 WSL, it can be downloaded from Microsoft Store.

GitHub-Pull: bitcoin#13246
Rebased-From: 9d4f942
@fanquake fanquake mentioned this pull request May 28, 2018
Merged
laanwj added a commit that referenced this pull request May 28, 2018
@laanwj
Merge #13336: [0.16.1] doc: Bump to Ubuntu Bionic 18.04 in build-wind…
224a41d 
…ows.md

6de7543 doc: Bump to Ubuntu Bionic 18.04 in build-windows.md (Chun Kuan Lee)

Pull request description:

  Windows starts to provide Ubuntu 18.04 WSL, it can be downloaded from Microsoft Store.

  GitHub-Pull: #13246
  Rebased-From: 9d4f942

Tree-SHA512: f72b97637fcedee4b21316ecafd43c5889111fedbc6522f805df40241558fdfe7579ad4b6bce1940890b3bc352fd64d428f13fb40e97f913031e7eccdc0f7ddf
HashUnlimited pushed a commit to chaincoin/chaincoin that referenced this pull request Jun 29, 2018
@ken2812221
doc: Bump to Ubuntu Bionic 18.04 in build-windows.md
7d930c4 
Windows starts to provide Ubuntu 18.04 WSL, it can be downloaded from Microsoft Store.

GitHub-Pull: bitcoin#13246
Rebased-From: 9d4f942
@Sjors Sjors mentioned this pull request Jul 17, 2018
Closed
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@laanwj laanwj laanwj left review comments

@fanquake fanquake fanquake left review comments

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ken2812221 @promag @fanquake @maflcko @laanwj