Skip to content

Conversation

@lost-tty
Copy link

Removes the bitcoin miner from the code (mining thread, RPCs, GUI options).

@jgarzik
Copy link
Contributor

jgarzik commented Mar 23, 2011

We should keep the miner, as a reference. People might start their own block chain, or perform research. BitcoinMiner() provides all that in a self-contained package.

Just hide it from the user in the GUI and command line help, IMO.

@jgarzik jgarzik closed this Mar 23, 2011
@jgarzik jgarzik reopened this Mar 23, 2011
@jgarzik
Copy link
Contributor

jgarzik commented Mar 23, 2011

Sorry, didn't mean to close the pull request, just comment.

@gavinandresen
Copy link
Contributor

The built-in miner is darn useful for -testnet (and testnet-in-a-box) testing.

Before removing it or hiding it in the client, content on the wiki and website needs to be updated, too.

@jhyslop
Copy link

jhyslop commented Mar 27, 2011

I pretty much agree with removing the miner from the client. Before mining gets removed, though, we should have a separate stand-alone miner as a reference implementation.

@jgarzik
Copy link
Contributor

jgarzik commented Mar 29, 2011

IMHO: remove 4way code, hide miner from GUI, leave reference miner in codebase.

@jgarzik
Copy link
Contributor

jgarzik commented May 6, 2011

Obsoleted by removal of 4way miner code

@jgarzik jgarzik closed this May 6, 2011
glv2 referenced this pull request in glv2/peercoin Nov 4, 2014
Fix column sorting in coin control dialog.
sipa added a commit to sipa/bitcoin that referenced this pull request Dec 4, 2014
b0210a9 Merge pull request bitcoin#135
ee3eb4b Fix a memory leak and add a number of small tests.
4d879a3 Merge pull request bitcoin#134
d5e8362 Merge pull request #127
7b92cf6 Merge pull request bitcoin#132
0bf70a5 Merge pull request bitcoin#133
29ae131 Make scalar_add_bit test's overflow detection exact
9048def Avoid undefined shift behaviour
efb7d4b Use constant-time conditional moves instead of byte slicing
d220062 Merge pull request #131
82f9254 Fix typo
601ca04 Merge pull request #129
35399e0 Bugfix: b is restricted, not r
c35ff1e Convert lambda splitter to pure scalar code.
cc604e9 Avoid division when decomposing scalars
ff8746d Add secp256k1_scalar_mul_shift_var
bd313f7 Merge pull request #119
276f987 Merge pull request #124
25d125e Merge pull request #126
24b3c65 Add a test case for ECDSA recomputing infinity
32600e5 Add a test for r >= order signature handling
4d4eeea Make secp256k1_fe_mul_inner use the r != property
be82e92 Require that r and b are different for field multiplication.
597128d Make num optional
659b554 Make constant initializers independent from num
0af5b47 Merge pull request #120
e2e8a36 Merge pull request #117
c76be9e Remove unused num functions
4285a98 Move lambda-splitting code to scalar.
f24041d Switch all EC/ECDSA logic from num to scalar
6794be6 Add scalar splitting functions
d1502eb Add secp256k1_scalar_inverse_var which delegates to GMP
b5c9ee7 Make test_point_times_order test meaningful again
0b73059 Switch wnaf splitting from num-based to scalar-based
1e6c77c Generalize secp256k1_scalar_get_bits
5213207 Add secp256k1_scalar_add_bit
3c0ae43 Merge pull request #122
6e05287 Do signature recovery/verification with 4 possible recid case
e3d692f Explain why no y=0 check is necessary for doubling
f7dc1c6 Optimize doubling: secp256k1 has no y=0 point
666d3b5 Merge pull request #121
2a54f9b Correct typo in comment
9d64145 Merge pull request #114
99f0728 Fix secp256k1_num_set_bin handling of 0
d907ebc Add bounds checking to field element setters
bb2cd94 Merge pull request #116
665775b Don't split the g factor when not using endomorphism
9431d6b Merge pull request #115
e2274c5 build: osx: attempt to work with homebrew keg-only packages

git-subtree-dir: src/secp256k1
git-subtree-split: b0210a9
dexX7 added a commit to dexX7/bitcoin that referenced this pull request Jul 23, 2015
13eb0bd Refine logging and handling of generated "Dev MSC" (dexX7)
b3673f8 Ensure there are STO recipients, before populating wallet cache (dexX7)
12152b7 As per default, don't log packet parsing in RPC mode (dexX7)
f920a03 Reduce txdb logging unless msc_debug_txdb specified (zathras-crypto)
283974a Don't log read-only calls to parseTransaction (zathras-crypto)
99b9ffc Do not attempt to update tally for 0 balances when loading state files (zathras-crypto)
keo pushed a commit to keo/bitcoin that referenced this pull request Mar 7, 2016
Add suport for deterministic armhf builds for 0.12
ptschip pushed a commit to ptschip/bitcoin that referenced this pull request Oct 27, 2016
Reduce bip68-112-113-p2p.py execution time from 30 to 2 min.
deadalnix pushed a commit to deadalnix/bitcoin that referenced this pull request Jan 19, 2017
efb7d4b Use constant-time conditional moves instead of byte slicing (Pieter Wuille)
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Dec 9, 2017
[ppcoin v0.6] Prevent premature activation of BIP34 softfork
classesjack pushed a commit to classesjack/bitcoin that referenced this pull request Jan 2, 2018
…ning

Fix initialization reorder warning on OSX
0xartem referenced this pull request in Crowndev/crown-core Feb 23, 2018
0xartem referenced this pull request in Crowndev/crown-core Feb 26, 2018
Fixed download cancel and start again issue (#132)

See merge request crown/crown-core!95
cryptapus added a commit to cryptapus/bitcoin that referenced this pull request Jan 31, 2019
Argon2d4096 Mining Algorithm Change
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Feb 23, 2019
Add Japanese translation about new masternode configure feature
rajarshimaitra pushed a commit to rajarshimaitra/bitcoin that referenced this pull request Aug 5, 2021
…blem

Centralization is still mentioned, but as an undesirable side effect. The first emphasis is on the limited scaling that can be done by simply increasing the block size
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants