Bugfix: ensure consistency of m_failed_blocks after reconsiderblock #13199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I think this should be marked for backport. |
sdaftuar
force-pushed
the
2018-05-fix-reconsider-block
branch
from
52eef2e to
11fa6bb
Compare
Member
|
utACK 11fa6bb |
sipa
added a commit
that referenced
this pull request
May 12, 2018
…onsiderblock 11fa6bb Bugfix: ensure consistency of m_failed_blocks after reconsiderblock (Suhas Daftuar) Pull request description: This was introduced in 015a525 and could cause a node to crash (due to assertion failure) when using the `reconsiderblock` rpc. Tree-SHA512: 820dcd761bf983e36f5d0f16777ed75c833daaf62a6b3a4dbd17f6caaf9287223e3a202d06540ac62f8ba72926b73b0873bb76c6273ddcb19d9408f4c1cd325e
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 24, 2018
Github-Pull: bitcoin#13199 Rebased-From: 11fa6bb
Member
|
Backported in #13317. |
HashUnlimited
pushed a commit
to chaincoin/chaincoin
that referenced
this pull request
Jun 29, 2018
Github-Pull: bitcoin#13199 Rebased-From: 11fa6bb
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jan 23, 2021
…ter reconsiderblock 11fa6bb Bugfix: ensure consistency of m_failed_blocks after reconsiderblock (Suhas Daftuar) Pull request description: This was introduced in 015a525 and could cause a node to crash (due to assertion failure) when using the `reconsiderblock` rpc. Tree-SHA512: 820dcd761bf983e36f5d0f16777ed75c833daaf62a6b3a4dbd17f6caaf9287223e3a202d06540ac62f8ba72926b73b0873bb76c6273ddcb19d9408f4c1cd325e
PastaPastaPasta
pushed a commit
to dashpay/dash
that referenced
this pull request
Feb 1, 2021
* Merge bitcoin#13199: Bugfix: ensure consistency of m_failed_blocks after reconsiderblock 11fa6bb Bugfix: ensure consistency of m_failed_blocks after reconsiderblock (Suhas Daftuar) Pull request description: This was introduced in 015a525 and could cause a node to crash (due to assertion failure) when using the `reconsiderblock` rpc. Tree-SHA512: 820dcd761bf983e36f5d0f16777ed75c833daaf62a6b3a4dbd17f6caaf9287223e3a202d06540ac62f8ba72926b73b0873bb76c6273ddcb19d9408f4c1cd325e * bugfix: Mark all nearest BLOCK_FAILED_CHILD descendants (if any) as BLOCK_FAILED_VALID while removing the invalidity flag from all ancestors in ResetBlockFailureFlags Fixes `Assertion failed: ((pindex->nStatus & BLOCK_FAILED_MASK) == 0), function CheckBlockIndex` * tests: Make sure ResetBlockFailureFlags does the job correctly * Wait for the expected block height, check the final chain tip hash Co-authored-by: Pieter Wuille <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in 015a525 and could cause a node to crash (due to assertion failure) when using the
reconsiderblockrpc.