Skip to content

Conversation

@Diapolo
Copy link

@Diapolo Diapolo commented May 15, 2012

@laanwj
Copy link
Member

laanwj commented May 16, 2012

The idea is great, however I don't think "obsolete" is the word to use here. It has very negative connotations.

Also, it would be nice if the tooltip explanation was more verbose, and explained to the user that they should wait until they catch up with the block chain until they can rely on the numbers shown (and not panic :-).

@Diapolo
Copy link
Author

Diapolo commented May 17, 2012

You are right, we should not scare users ^^. Will change the strings.

@Diapolo
Copy link
Author

Diapolo commented May 17, 2012

Updated to be less scaring and more verbose.

@Diapolo
Copy link
Author

Diapolo commented May 17, 2012

I'm tuning the layout a little currently, please wait for a final rebase before merging @laanwj.

@Diapolo
Copy link
Author

Diapolo commented May 17, 2012

Updated tooltip once more, changed tr() handling, to not need to translate "(" and ")" and fixed use stylesheet in the UI-file. If @laanwj you feel the text is now better this can be merged.

@laanwj
Copy link
Member

laanwj commented May 17, 2012

I think at least one native English speaker should check this, but some remarks:

  • Never display "(up to date)". Only display "(out of sync)" when the block chain is out of sync. After all, there is never a guarantee that the client is up to date, only an indication that it is not. See the original issue Usability: During initial sync its not obvious that txn will not be displayed #1236.
  • Message: Wallet state, displays "out of sync" while block chain sync needs to be done and "up to date", if the local block chain is synced to the network. Remember, "out of sync" is a normal state, no Bitcoins are lost!:
    • No need to mention "wallet state", or "no bitcoins are lost!". I think it is better to show the message (when the user hovers over any "out of sync"), as:
    • The displayed information reflects an older state. The local block chain needs to be synchronized to the network to get more recent information. This will happen automatically when there is connectivity to the network.
    • Show no message when not out of sync

I think the message can be even more simpler and more verbose/friendly English, but this is the idea.

@Diapolo
Copy link
Author

Diapolo commented May 17, 2012

I agree to hide the message if everything is okay ... will update. Have to think about the message-text again ;) ... will take your suggestion as base.

@Diapolo
Copy link
Author

Diapolo commented May 17, 2012

@laanwj My suggestion is: The displayed information reflects an older state. To get more recent information, the local block chain needs to be synced with the network. This process starts automatically after a network connection is established.

@laanwj
Copy link
Member

laanwj commented May 17, 2012

Yes, ok with me.
(btw, you have a space before the message in your commit :-)

@Diapolo
Copy link
Author

Diapolo commented May 17, 2012

@laanwj OMFG that needs an update :), thanks for mentioning!

@Diapolo
Copy link
Author

Diapolo commented May 17, 2012

Finished :-D!?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using one function that takes a boolean

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to be a single function.

@laanwj
Copy link
Member

laanwj commented May 17, 2012

As for the messages, maybe it'd be good if @gmaxwell takes a look too. He opened the original issue.

…status (obsolete or current) / cleanup overviewpage XML ui-file
@Diapolo
Copy link
Author

Diapolo commented May 17, 2012

Updated to @gmaxwell phrasing suggestion.

laanwj added a commit that referenced this pull request May 17, 2012
…ewpage

GUI: add 2 labels to the overviewpage that display Wallet and Transaction status
@laanwj laanwj merged commit f0fc95a into bitcoin:master May 17, 2012
coblee pushed a commit to litecoin-project/litecoin that referenced this pull request Jul 17, 2012
…_Overviewpage

GUI: add 2 labels to the overviewpage that display Wallet and Transaction status
suprnurd pushed a commit to chaincoin-legacy/chaincoin that referenced this pull request Dec 5, 2017
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Jan 22, 2019
…reason), the code does not work as expected (it does not print the error, and doesn't ignore failures in the argument to since the problem happens during args eval. This restores the expected functionality (bitcoin#1314)
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request May 6, 2020
…t cleaning

79dccae [Trivial][RPC] Fix spendzerocoin num of arguments (random-zebra)
c9aefbf [Doc] Update rel notes: remove zPIV backup - mintchange/minimizechange (random-zebra)
35dae21 [Cleanup][Trivial] Remove unused variable nStakeSetUpdateTime in wallet (random-zebra)
f95af41 [Wallet][Cleanup] Refactor zPIV legacy functions at the end of wallet.* (random-zebra)
565b963 [Wallet][RPC] Remove fMintChange / fMinimizeChange from zc spends/mints (random-zebra)
76b7386 [Wallet][zPIV] Remove auto-backups. Lock minting only for tests. (random-zebra)

Pull request description:

  Builds on top of bitcoin#1293 .
  This removes zerocoin backups and locks minting only for tests. Mints and v2 spends are rejected from mempool. Removes `fMintChange/fMinimizeChange` options from RPC functions. Cleans up unused variables and functions. Zerocoin specific implementations have been moved from wallet.cpp to a new file wallet_zerocoin.cpp in the wallet directory.

ACKs for top commit:
  furszy:
    cool refactor, utACK 79dccae.
  Fuzzbawls:
    ACK 79dccae

Tree-SHA512: bb69e9e79e2a5664d351fdce1a35a16642576290ead7198e74b04213b478a5e1e9a96ff9aa800ca714c5c6f2045e780a533921681d2ab79af6761a8acebec7c8
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants