-
Notifications
You must be signed in to change notification settings - Fork 38.7k
GUI: add 2 labels to the overviewpage that display Wallet and Transaction status #1314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI: add 2 labels to the overviewpage that display Wallet and Transaction status #1314
Conversation
Diapolo
commented
May 15, 2012
- cleanup overviewpage XML ui-file
- addresses: Usability: During initial sync its not obvious that txn will not be displayed #1236
|
The idea is great, however I don't think "obsolete" is the word to use here. It has very negative connotations. Also, it would be nice if the tooltip explanation was more verbose, and explained to the user that they should wait until they catch up with the block chain until they can rely on the numbers shown (and not panic :-). |
|
You are right, we should not scare users ^^. Will change the strings. |
|
Updated to be less scaring and more verbose. |
|
I'm tuning the layout a little currently, please wait for a final rebase before merging @laanwj. |
|
Updated tooltip once more, changed tr() handling, to not need to translate "(" and ")" and fixed use stylesheet in the UI-file. If @laanwj you feel the text is now better this can be merged. |
|
I think at least one native English speaker should check this, but some remarks:
I think the message can be even more simpler and more verbose/friendly English, but this is the idea. |
|
I agree to hide the message if everything is okay ... will update. Have to think about the message-text again ;) ... will take your suggestion as base. |
|
@laanwj My suggestion is: The displayed information reflects an older state. To get more recent information, the local block chain needs to be synced with the network. This process starts automatically after a network connection is established. |
|
Yes, ok with me. |
|
@laanwj OMFG that needs an update :), thanks for mentioning! |
|
Finished :-D!? |
src/qt/overviewpage.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest using one function that takes a boolean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to be a single function.
|
As for the messages, maybe it'd be good if @gmaxwell takes a look too. He opened the original issue. |
…status (obsolete or current) / cleanup overviewpage XML ui-file
|
Updated to @gmaxwell phrasing suggestion. |
…ewpage GUI: add 2 labels to the overviewpage that display Wallet and Transaction status
…_Overviewpage GUI: add 2 labels to the overviewpage that display Wallet and Transaction status
…reason), the code does not work as expected (it does not print the error, and doesn't ignore failures in the argument to since the problem happens during args eval. This restores the expected functionality (bitcoin#1314)
…t cleaning 79dccae [Trivial][RPC] Fix spendzerocoin num of arguments (random-zebra) c9aefbf [Doc] Update rel notes: remove zPIV backup - mintchange/minimizechange (random-zebra) 35dae21 [Cleanup][Trivial] Remove unused variable nStakeSetUpdateTime in wallet (random-zebra) f95af41 [Wallet][Cleanup] Refactor zPIV legacy functions at the end of wallet.* (random-zebra) 565b963 [Wallet][RPC] Remove fMintChange / fMinimizeChange from zc spends/mints (random-zebra) 76b7386 [Wallet][zPIV] Remove auto-backups. Lock minting only for tests. (random-zebra) Pull request description: Builds on top of bitcoin#1293 . This removes zerocoin backups and locks minting only for tests. Mints and v2 spends are rejected from mempool. Removes `fMintChange/fMinimizeChange` options from RPC functions. Cleans up unused variables and functions. Zerocoin specific implementations have been moved from wallet.cpp to a new file wallet_zerocoin.cpp in the wallet directory. ACKs for top commit: furszy: cool refactor, utACK 79dccae. Fuzzbawls: ACK 79dccae Tree-SHA512: bb69e9e79e2a5664d351fdce1a35a16642576290ead7198e74b04213b478a5e1e9a96ff9aa800ca714c5c6f2045e780a533921681d2ab79af6761a8acebec7c8