[tests] Fix flake8 warnings in several wallet functional tests #13136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
May 1, 2018
test/functional/wallet_basic.py
Outdated
Member
There was a problem hiding this comment.
If you add a space here, then make it consistently for the second kv as well
maflcko
reviewed
May 1, 2018
Member
|
utACK 5ec11f44f322be851746903578bd5224b9807e51. I am not aware of any significant pull request that would conflict due to this, so it seems fine. |
ryanofsky
reviewed
May 1, 2018
Contributor
ryanofsky
left a comment
ryanofsky
left a comment
There was a problem hiding this comment.
utACK 5ec11f44f322be851746903578bd5224b9807e51
This commit fixes flake8 warnings in the following functional tests: - wallet_listreceivedby.py - wallet_basic.py - wallet_txn_clone.py - wallet_listsinceblock.py - wallet_import_rescan.py - wallet_listtransactions.py - wallet_importprunedfunds.py - wallet_txn_doublspend.py
jnewbery
force-pushed
the
wallet_test_flake8
branch
from
5ec11f4 to
a533834
Compare
Contributor
Author
|
@MarcoFalke - addressed your comments. I've also fixed a couple of variable names which I somehow missed before. @ryanofsky - Thanks for the quick review. |
Member
|
re-utACK a533834 |
ryanofsky
reviewed
May 1, 2018
Member
|
Note that this is no longer [trivial] since you change variable names and remove assignments... |
maflcko
changed the title
maflcko
pushed a commit
that referenced
this pull request
May 1, 2018
…l tests a533834 [tests] Fix flake8 warnings in several wallet functional tests (John Newbery) Pull request description: Fixes flake8 warnings in several wallet functional tests. Several wallet functional tests need rewrite to remove the accounts API (#13075). To prepare for that, I fixed all the flake8 warnings in those tests. #13075 is blocked on a bitcoind bug. This PR is just the flake8 fixes so we're not completely blocked. Tree-SHA512: 2dc1d589b2f8f4318083a681e487532d0f8f3d57e8bc8f37b660b728ffc33329b88e9251eb223104aea89f293c3f4074ca700fe690e645617326b859da3e93c3
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 1, 2020
Summary: Note: This backport apparently was skipped due to being (mostly) irrelevant changes that our linter takes care of anyway. But there was one line of code changed on wallet_basic and a few variable name changes that are being a pain, so I'm bringing in the relevant parts. Backport of Core [[bitcoin/bitcoin#13136 | PR13136]] (hiding whitespace changes makes this easier) Test Plan: ninja all check check-functional Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D7716
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
May 25, 2021
…nctional tests a533834 [tests] Fix flake8 warnings in several wallet functional tests (John Newbery) Pull request description: Fixes flake8 warnings in several wallet functional tests. Several wallet functional tests need rewrite to remove the accounts API (bitcoin#13075). To prepare for that, I fixed all the flake8 warnings in those tests. bitcoin#13075 is blocked on a bitcoind bug. This PR is just the flake8 fixes so we're not completely blocked. Tree-SHA512: 2dc1d589b2f8f4318083a681e487532d0f8f3d57e8bc8f37b660b728ffc33329b88e9251eb223104aea89f293c3f4074ca700fe690e645617326b859da3e93c3
TheArbitrator
pushed a commit
to TheArbitrator/dash
that referenced
this pull request
Jun 4, 2021
…nctional tests a533834 [tests] Fix flake8 warnings in several wallet functional tests (John Newbery) Pull request description: Fixes flake8 warnings in several wallet functional tests. Several wallet functional tests need rewrite to remove the accounts API (bitcoin#13075). To prepare for that, I fixed all the flake8 warnings in those tests. bitcoin#13075 is blocked on a bitcoind bug. This PR is just the flake8 fixes so we're not completely blocked. Tree-SHA512: 2dc1d589b2f8f4318083a681e487532d0f8f3d57e8bc8f37b660b728ffc33329b88e9251eb223104aea89f293c3f4074ca700fe690e645617326b859da3e93c3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flake8 warnings in several wallet functional tests.
Several wallet functional tests need rewrite to remove the accounts API (#13075). To prepare for that, I fixed all the flake8 warnings in those tests.
#13075 is blocked on a bitcoind bug. This PR is just the flake8 fixes so we're not completely blocked.