[bugfix] [wallet] Fix zapwallettxes/multiwallet interaction. #13030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-zapwallettxes should be disallowed when starting bitcoin in multiwallet mode.
Add a test to check that bitcoind fails to start when specifying -zapwallettxes, -salvagewallet and -upgradewallet when running in multiwallet mode.
Member
|
utACK 1f83839 ( |
Member
|
utACK 1f83839 |
laanwj
added a commit
that referenced
this pull request
Apr 23, 2018
…tion. 1f83839 [wallet] [tests] Test disallowed multiwallet params (John Newbery) 3476e3c [wallet] Fix zapwallettxes/multiwallet interaction. (John Newbery) Pull request description: `-zapwallettxes` should be disallowed when starting bitcoin in multiwallet mode. There's code in `WalletInit::ParameterInteraction()` to disallow `-zapwallettxes` when running in multiwallet mode. This code functioned as expected when passing the parameter `-zapwallettxes=1`, but not when passing the parameter `-zapwallettxes` (ie without the value specified). Fix that and add a test. The new test in the _[wallet] [tests] Test disallowed multiwallet params_ commit reproduces the bug and should fail against master. Fixes #12505 Tree-SHA512: 6cd921717e9c7d2773ca84c946c310c2adec8430e37cbecdb33a620f510db3058a72bd328411812ba415111bc52a3367b332c9d15a37a92ccfd7ae785d2f32ab
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
May 17, 2018
-zapwallettxes should be disallowed when starting bitcoin in multiwallet mode. GitHub-Pull: bitcoin#13030 Rebased-From: 3476e3c
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
May 18, 2018
Add a test to check that bitcoind fails to start when specifying -zapwallettxes, -salvagewallet and -upgradewallet when running in multiwallet mode. GitHub-Pull: bitcoin#13030 Rebased-From: 1f83839
laanwj
added a commit
that referenced
this pull request
May 24, 2018
acdf433 Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTip (Jesse Cohen) 5ff571e [wallet] [tests] Test disallowed multiwallet params (John Newbery) 4c14e7b [wallet] Fix zapwallettxes/multiwallet interaction. (John Newbery) 4087dd0 RPC Docs: gettxout*: clarify bestblock and unspent counts (David A. Harding) b8aacd6 [qa] Handle disconnect_node race (Suhas Daftuar) Pull request description: Backports: - #13201 [qa] Handle disconnect_node race - #13184 RPC Docs: gettxout*: clarify bestblock and unspent counts - #13030 [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction. - #12988 Hold cs_main while calling UpdatedBlockTip() signal to the 0.16 branch. Tree-SHA512: 8f65002bbafaf9c436f89051b2d79bf6a668fbd07bd317c64af238ed4a7c8efe776864b739a7f2869f1e3daa16f2f4366a85f41b188f9c454879d2c7b309be50
HashUnlimited
pushed a commit
to chaincoin/chaincoin
that referenced
this pull request
Jun 29, 2018
-zapwallettxes should be disallowed when starting bitcoin in multiwallet mode. GitHub-Pull: bitcoin#13030 Rebased-From: 3476e3c
HashUnlimited
pushed a commit
to chaincoin/chaincoin
that referenced
this pull request
Jun 29, 2018
Add a test to check that bitcoind fails to start when specifying -zapwallettxes, -salvagewallet and -upgradewallet when running in multiwallet mode. GitHub-Pull: bitcoin#13030 Rebased-From: 1f83839
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Nov 17, 2020
…interaction. 1f83839 [wallet] [tests] Test disallowed multiwallet params (John Newbery) 3476e3c [wallet] Fix zapwallettxes/multiwallet interaction. (John Newbery) Pull request description: `-zapwallettxes` should be disallowed when starting bitcoin in multiwallet mode. There's code in `WalletInit::ParameterInteraction()` to disallow `-zapwallettxes` when running in multiwallet mode. This code functioned as expected when passing the parameter `-zapwallettxes=1`, but not when passing the parameter `-zapwallettxes` (ie without the value specified). Fix that and add a test. The new test in the _[wallet] [tests] Test disallowed multiwallet params_ commit reproduces the bug and should fail against master. Fixes bitcoin#12505 Tree-SHA512: 6cd921717e9c7d2773ca84c946c310c2adec8430e37cbecdb33a620f510db3058a72bd328411812ba415111bc52a3367b332c9d15a37a92ccfd7ae785d2f32ab
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-zapwallettxesshould be disallowed when starting bitcoin in multiwallet mode.There's code in
WalletInit::ParameterInteraction()to disallow-zapwallettxeswhen running in multiwallet mode. This code functioned as expected when passing the parameter-zapwallettxes=1, but not when passing the parameter-zapwallettxes(ie without the value specified). Fix that and add a test.The new test in the
[wallet] [tests] Test disallowed multiwallet params commit reproduces the bug and should fail against master.
Fixes #12505