Get rid of snprintf (except one) with fixed buffers, shorten code #1302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
laanwj
commented
May 14, 2012
laanwj
commented
- Use strprintf or vstrprintf instead of snprintf
- Use strprintf or vstrprintf instead of snprintf
Contributor
|
looks good to my quick scan |
|
Looks good and get's rid of some damn char arrays and buffer-fiddling! ACK |
Contributor
|
ACK. |
laanwj
added a commit
that referenced
this pull request
May 20, 2012
Get rid of snprintf (except one) with fixed buffers, shorten code
coblee
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Jul 17, 2012
Get rid of snprintf (except one) with fixed buffers, shorten code
MitchellCash
pushed a commit
to MitchellCash/paycoin
that referenced
this pull request
Dec 6, 2015
- Use strprintf or vstrprintf instead of snprintf reference: bitcoin/bitcoin#1302
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
May 6, 2020
…te out of main f578a68 Move CValidationState to consensus subdir (Fuzzbawls) 083cc4d Use AbortNode instead of state.Abort (Fuzzbawls) ad77d3d Move consensus constants to consensus.h (Fuzzbawls) c210d20 Move CBlockTemplate from main.h to miner.h (Fuzzbawls) 4d8b9ce Move CBlockFileInfo class from main.h to chain.h (Fuzzbawls) 668ac61 Refactor nMaxMoneyOut back to amount.h (Fuzzbawls) Pull request description: This is the first part of bitcoin#1209 that moves the CBlockFileInfo and CValidationState classes (and their supporting constants) out of `main.cpp(.h)` @barrystyle's original commits have been further split to assist in review-ability ease. I left the refactor of `nMaxMoneyOut` and `CBlockTemplate` included here as they are rather straight forward, however they each now are in their own respective commits. ACKs for top commit: random-zebra: utACK f578a68 furszy: utACK f578a68 Tree-SHA512: 4433aacde02be0479d6c8ac3d6d4d725c4ed5518c82a412539e791f62b63516f042828c0407a697b4018c8f92965425f05837293a38d6da890a98bdf0e4e9dfe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.