test: Fix dangling wallet pointer in vpwallets #13007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
changed the title
Member
|
This is refactoring and doesn't fix a bug or anything? |
Contributor
Author
|
No, I came across this "bad code" in a another branch and I thought this could already be "fixed". The first wallet is destroyed and it's pointer is kept in |
Member
|
utACK d41a420. Code looks slightly cleaner, since the unused pointer is dropped after use. |
laanwj
added a commit
that referenced
this pull request
Apr 18, 2018
d41a420 test: Fix dangling wallet pointer in vpwallets (João Barbosa) Pull request description: Tree-SHA512: 83e4ec571f1675b3dab6f7606f29d6fae495d998b4e5794ff14315943783d4518cfa66eba4113293e349eb74aa22a024b21272fdb29c212477edb4c09aec9fa7
UdjinM6
pushed a commit
to dashpay/dash
that referenced
this pull request
Aug 24, 2020
…3666) * test: Fix importwallet_rescan test The wallet should be removed after the dumpwallet() call otherwise it may lead to unepexted behaviour in other wallet tests since the wallet stays in vpwallets then. * tests: Change where RemoveWallet call is to be more in line with upstream Signed-off-by: pasta <[email protected]> Co-authored-by: pasta <[email protected]>
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 8, 2020
…ashpay#3666) * test: Fix importwallet_rescan test The wallet should be removed after the dumpwallet() call otherwise it may lead to unepexted behaviour in other wallet tests since the wallet stays in vpwallets then. * tests: Change where RemoveWallet call is to be more in line with upstream Signed-off-by: pasta <[email protected]> Co-authored-by: pasta <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.