Use boost::thread locking instead of interprocess #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ACK |
1 similar comment
Member
|
ACK |
Contributor
|
boost::interprocess::interprocess_mutex dd_mutex in DEBUG_LOCKORDER? (Edit: and, indeed, DEBUG_LOCKORDER is currently broken) |
Member
Author
|
Fixed DEBUG_LOCKORDER. |
src/makefile.unix
Outdated
Member
There was a problem hiding this comment.
I don't think this should sneak into the makefile :)
Contributor
|
ACK, good CPU usage on my mac. |
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
* Shift PS denoms * fix ui PS restrictions
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
May 6, 2020
3f98b37 [CMake] Check for and require Qt 5.5.1 minimum version (Fuzzbawls) 19ce9de build: Refactor out Qt version check macro (Fuzzbawls) 2c18e82 Bump minimum required Qt to 5.5.1 (Fuzzbawls) Pull request description: As per bitcoin#1292, this effectively bumps the minimum required Qt version to 5.5.1. - Removed no longer needed precompiler conditionals - Updated autotools to check for and require at least 5.5.1 to build the GUI - Updated CMake to check for and require at least 5.5.1 to build the `pivx-qt` target Closes bitcoin#1292 ACKs for top commit: random-zebra: ACK 3f98b37 furszy: looking good, utACK 3f98b37 Tree-SHA512: 32e494ea7f166ce57a9be08dbfcc067546f4e0c46ccc8b9a4836dd148243ca14e1fede166cccdb6ae6ddbae8f0832362a6935e42742ed957b41be3104511bdd0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Luke noticed there was a boost/thread/* set of synchronisation primitives, separate from those in boost/interprocess/sync/*. Given that they do not need to cope with locks being in shared memory, they are different and simpler on some systems.
This commit replaces all sync.{h,cpp} infrastructure by systems provided by boost/thread/*.
So far, it seems to work well on Linux, OSX and BSD (the latter two required a workaround before, as the interprocess semaphores and condition variables used spinlocks - it seems the thread ones don't).