Fix version numbers of archive builds #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Add a comment in the code, indicating this special condition... |
Member
|
Hmm. Alright. |
Member
Author
|
@jgarzik: added |
|
LOL @ the comment! |
gmaxwell
added a commit
that referenced
this pull request
May 11, 2012
Fix version numbers of archive builds
coblee
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Jul 17, 2012
Fix version numbers of archive builds
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
* Fix variable shadowing in blockstorage/sequential_files.cpp
blockstorage/sequential_files.cpp:178:71: warning: declaration shadows a local variable [-Wshadow]
std::multimap<CBlockIndex *, CBlockIndex *>::iterator it = range.first;
^
blockstorage/sequential_files.cpp:157:29: note: previous declaration is here
for (BlockMap::iterator it = mapBlockIndex.begin(); it != mapBlockIndex.end(); ++it)
* Fix variable shadowing in blockstorage/blockstorage.cpp
there was a redundant definition of a state variable that produced this warn:
blockstorage/blockstorage.cpp:127:34: warning: declaration shadows a local variable [-Wshadow]
CValidationState state;
^
blockstorage/blockstorage.cpp:114:26: note: previous declaration is here
CValidationState state;
* Remove unused variable in src/txdb.cpp
* Fix [-Wsign-compare] warns in blocksdb code
These are the warning as produced by clang:
blockstorage/blockleveldb.cpp:121:35: warning: comparison of integers of different signs: 'int' and 'uint64_t' (aka 'unsigned long') [-Wsign-compare]
if (pindexOldest->nHeight >= nLastBlockWeCanPrune)
~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~
blockstorage/blockstorage.cpp:404:34: warning: comparison of integers of different signs: 'uint64_t' (aka 'unsigned long') and 'int' [-Wsign-compare]
if (lastFinishedFile <= loadedblockfile && index->nHeight > blockfiles[lastFinishedFile].nHeightLast)
~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~
blockstorage/blockstorage.cpp:404:71: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
if (lastFinishedFile <= loadedblockfile && index->nHeight > blockfiles[lastFinishedFile].nHeightLast)
~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
blockstorage/blockstorage.cpp:681:69: warning: comparison of integers of different signs: 'long' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
if (nCoinCacheMaxSize - nMaxCacheIncreaseSinceLastFlush > nTrimSize)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preprocessor magic in version.cpp require CLIENT_VERSION_* to be macro's, as they are stringified into CLIENT_DESC when no git-describe output is available.