scripted-diff: Rename key size consts to be relative to their class #12461

Empact · 2018-02-16T20:39:27Z

~~And introduce CPubKeySig to host code relative to key sigs.~~

devrandom · 2018-02-16T21:22:07Z

utACK b0e8b72

src/pubkey.h

jonasschnelli · 2018-02-17T11:12:48Z

Concept ACK.
Not sure if CPubKeySig needs its own space.

Empact · 2018-02-19T00:26:11Z

Thanks, made PubKeySig a namespace.

Empact · 2018-02-20T20:51:09Z

On second thought, dropped PubKeySig - without any other code it's barely a separate concern.

instagibbs · 2018-02-26T19:01:42Z

seemingly unrelated travis error:

File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/rpc_net.py", line 54, in _test_getnettotals
assert_equal(before['bytesrecv_per_msg']['pong'] + 32, after['bytesrecv_per_msg']['pong'])

kicked travis

Empact · 2018-02-26T19:35:25Z

@instagibbs thanks - seems like that is a timing-related failure, I pushed #12545 to increase the wait, and reduce the likelihood of spurious failures.

maflcko · 2018-03-19T01:10:42Z

Needs rebase if still relevant

Empact · 2018-03-21T07:01:42Z

Rebased

Empact · 2018-04-12T20:32:03Z

Rebased & reimplemented as a scripted-diff

sipa · 2018-05-17T00:16:42Z

utACK f1583f26f2d9cb199ace6054a67797e1d4d9bed0

Empact · 2018-06-01T12:18:51Z

Rebased and updated to cover #13194

maflcko · 2018-09-07T18:04:36Z

utACK 2dda5dd034, but please note that the scripted diff will modify files outside the git tree. I'd prefer to avoid that.

Empact · 2018-09-11T04:55:04Z

Updated to include 2 new cases, and brought it down to a single sed call which only acts on files in the repo.

Empact · 2018-09-15T17:35:07Z

Rebased for #14195

ken2812221

utACK 40c69642bd4bed49d17b75e3f544afbc8d10e8ae

src/pubkey.h

DrahtBot · 2018-12-17T12:50:54Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#16463 ([BIP 174] Implement serialization support for GLOBAL_XPUB field. by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Empact · 2019-03-04T09:28:36Z

Rebased, added a commit to fixup whitespace.

…EY_SIZE To SIZE and COMPRESSED_SIZE -BEGIN VERIFY SCRIPT- sed -i 's/PRIVATE_KEY_SIZE/SIZE/g' src/*.h src/*.cpp src/**/*.h src/**/*.cpp sed -i 's/COMPRESSED_PRIVATE_KEY_SIZE/COMPRESSED_SIZE/g' src/*.h src/**/*.cpp src/**/*.h src/**/*.cpp sed -i 's/PUBLIC_KEY_SIZE/SIZE/g' src/*.h src/*.cpp src/**/*.h src/**/*.cpp sed -i 's/COMPRESSED_PUBLIC_KEY_SIZE/COMPRESSED_SIZE/g' src/*.h src/*.cpp src/**/*.h src/**/*.cpp -END VERIFY SCRIPT-

meshcollider · 2019-04-14T04:01:59Z

utACK 0580f86

… their class 0580f86 Fixup whitespace (Ben Woosley) 47101bb scripted-diff: Rename CPubKey and CKey::*_KEY_SIZE and COMPRESSED_*_KEY_SIZE (Ben Woosley) Pull request description: ~~And introduce CPubKeySig to host code relative to key sigs.~~ ACKs for top commit: meshcollider: utACK 0580f86 Tree-SHA512: 29aa0be54912358b138e391b9db78639786f56580493e590ec9f773c0e1b421740133d05a79be247c7ee57e71c9c9e41b9cb54088cb3c0e3f813f74f0895287b

…tive to their class 0580f86 Fixup whitespace (Ben Woosley) 47101bb scripted-diff: Rename CPubKey and CKey::*_KEY_SIZE and COMPRESSED_*_KEY_SIZE (Ben Woosley) Pull request description: ~~And introduce CPubKeySig to host code relative to key sigs.~~ ACKs for top commit: meshcollider: utACK bitcoin@0580f86 Tree-SHA512: 29aa0be54912358b138e391b9db78639786f56580493e590ec9f773c0e1b421740133d05a79be247c7ee57e71c9c9e41b9cb54088cb3c0e3f813f74f0895287b

… to their class Summary: -BEGIN VERIFY SCRIPT- sed -i 's/PRIVATE_KEY_SIZE/SIZE/g' src/*.h src/*.cpp src/**/*.h src/**/*.cpp sed -i 's/COMPRESSED_PRIVATE_KEY_SIZE/COMPRESSED_SIZE/g' src/*.h src/**/*.cpp src/**/*.h src/**/*.cpp sed -i 's/PUBLIC_KEY_SIZE/SIZE/g' src/*.h src/*.cpp src/**/*.h src/**/*.cpp sed -i 's/COMPRESSED_PUBLIC_KEY_SIZE/COMPRESSED_SIZE/g' src/*.h src/*.cpp src/**/*.h src/**/*.cpp -END VERIFY SCRIPT- --- Backport of Core [[bitcoin/bitcoin#12461 | PR12461]] Test Plan: ninja all check check-functional Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7812

…tive to their class 0580f86 Fixup whitespace (Ben Woosley) 47101bb scripted-diff: Rename CPubKey and CKey::*_KEY_SIZE and COMPRESSED_*_KEY_SIZE (Ben Woosley) Pull request description: ~~And introduce CPubKeySig to host code relative to key sigs.~~ ACKs for top commit: meshcollider: utACK bitcoin@0580f86 Tree-SHA512: 29aa0be54912358b138e391b9db78639786f56580493e590ec9f773c0e1b421740133d05a79be247c7ee57e71c9c9e41b9cb54088cb3c0e3f813f74f0895287b

Empact mentioned this pull request Feb 16, 2018

Add header-sensitive size checking via CPubKey::ValidSize, and prefer key/sig size const references #12319

Closed

fanquake added the Refactoring label Feb 17, 2018

jonasschnelli reviewed Feb 17, 2018

View reviewed changes

src/pubkey.h Outdated Show resolved Hide resolved

Empact force-pushed the key-size-consts branch 2 times, most recently from 5393631 to ab4cd44 Compare February 19, 2018 00:14

Empact force-pushed the key-size-consts branch from ab4cd44 to b43706d Compare February 20, 2018 20:50

Empact changed the title ~~Refactor key / signature size consts to be relative to their relevant class~~ Refactor key size consts to be relative to their relevant class Feb 20, 2018

Empact force-pushed the key-size-consts branch 2 times, most recently from b5957ae to cf531e2 Compare March 19, 2018 18:26

fanquake requested a review from sipa March 21, 2018 07:16

Empact force-pushed the key-size-consts branch 2 times, most recently from 73ad574 to b57fa2a Compare April 12, 2018 20:31

Empact changed the title ~~Refactor key size consts to be relative to their relevant class~~ scripted-diff: Rename key size consts to be relative to their class Apr 12, 2018

Empact force-pushed the key-size-consts branch 2 times, most recently from bb3f151 to f1583f2 Compare April 17, 2018 09:11

Empact mentioned this pull request May 16, 2018

Remove template matching and pseudo opcodes #13194

Merged

Empact force-pushed the key-size-consts branch from f1583f2 to 0be4880 Compare June 1, 2018 12:18

Empact force-pushed the key-size-consts branch from 0be4880 to 50c0d61 Compare June 1, 2018 13:15

Empact force-pushed the key-size-consts branch from 50c0d61 to 2dda5dd Compare July 17, 2018 17:14

maflcko closed this Sep 7, 2018

maflcko reopened this Sep 7, 2018

DrahtBot mentioned this pull request Sep 11, 2018

Pass privkey export DER compression flag correctly #14195

Closed

Empact force-pushed the key-size-consts branch 2 times, most recently from bf342f1 to b9bc812 Compare September 11, 2018 04:54

DrahtBot added the Needs rebase label Sep 13, 2018

Empact force-pushed the key-size-consts branch from b9bc812 to 40c6964 Compare September 15, 2018 17:34

DrahtBot removed the Needs rebase label Sep 15, 2018

ken2812221 approved these changes Dec 2, 2018

View reviewed changes

src/pubkey.h Outdated Show resolved Hide resolved

DrahtBot added the Needs rebase label Feb 14, 2019

Empact force-pushed the key-size-consts branch from 40c6964 to 1a6fdd0 Compare March 4, 2019 09:26

Empact added 2 commits March 4, 2019 01:30

Fixup whitespace

0580f86

Empact force-pushed the key-size-consts branch from 1a6fdd0 to 0580f86 Compare March 4, 2019 09:30

DrahtBot removed the Needs rebase label Mar 4, 2019

laanwj merged commit 0580f86 into bitcoin:master Nov 20, 2019

MarkLTZ mentioned this pull request Apr 4, 2020

Bitcoin PR tracking litecoinz-core/litecoinz#14

Closed

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

scripted-diff: Rename key size consts to be relative to their class #12461

scripted-diff: Rename key size consts to be relative to their class #12461

Uh oh!

Conversation

Empact commented Feb 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devrandom commented Feb 16, 2018

Uh oh!

Uh oh!

jonasschnelli commented Feb 17, 2018

Uh oh!

Empact commented Feb 19, 2018

Uh oh!

Empact commented Feb 20, 2018

Uh oh!

instagibbs commented Feb 26, 2018

Uh oh!

Empact commented Feb 26, 2018

Uh oh!

maflcko commented Mar 19, 2018

Uh oh!

Empact commented Mar 21, 2018

Uh oh!

Empact commented Apr 12, 2018

Uh oh!

sipa commented May 17, 2018

Uh oh!

Empact commented Jun 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko commented Sep 7, 2018

Uh oh!

Empact commented Sep 11, 2018

Uh oh!

Empact commented Sep 15, 2018

Uh oh!

ken2812221 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DrahtBot commented Dec 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

Empact commented Mar 4, 2019

Uh oh!

meshcollider commented Apr 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Empact commented Feb 16, 2018 •

edited

Loading

Empact commented Jun 1, 2018 •

edited

Loading

DrahtBot commented Dec 17, 2018 •

edited

Loading