Skip to content

Conversation

@meshcollider
Copy link
Contributor

@meshcollider meshcollider commented Feb 15, 2018

In the case that a test fails, the typo in run_tests() (introduced in #11858) will cause an error rather than printing out the combined logs, hiding the cause of the failure.

@fanquake fanquake added the Tests label Feb 15, 2018
@fanquake
Copy link
Member

utACK ada1af6

1 similar comment
@esotericnonsense
Copy link
Contributor

utACK ada1af6

@maflcko
Copy link
Member

maflcko commented Feb 15, 2018

Thanks. utACK ada1af6

@maflcko maflcko merged commit ada1af6 into bitcoin:master Feb 15, 2018
maflcko pushed a commit that referenced this pull request Feb 15, 2018
ada1af6 Fix typo in test_runner.py causing error (MeshCollider)

Pull request description:

  In the case that a test fails, the typo in run_tests() (introduced in #11858) will cause an error rather than printing out the combined logs, hiding the cause of the failure.

Tree-SHA512: 7d7aa406d92750320ed20610cc5f174cdc94086f630af8c0c4db2003497132e0c56d59b94312fb42ad4507904a2fa858226a4a9337450930bf206183fc35c0a0
@meshcollider meshcollider deleted the 201802_fix_testrunner_typo branch February 15, 2018 04:48
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 17, 2020
…ng error

ada1af6 Fix typo in test_runner.py causing error (MeshCollider)

Pull request description:

  In the case that a test fails, the typo in run_tests() (introduced in bitcoin#11858) will cause an error rather than printing out the combined logs, hiding the cause of the failure.

Tree-SHA512: 7d7aa406d92750320ed20610cc5f174cdc94086f630af8c0c4db2003497132e0c56d59b94312fb42ad4507904a2fa858226a4a9337450930bf206183fc35c0a0
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants