[qt] send: Clear All also resets coin control options #12432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
utACK f506c0a. |
Contributor
|
utACK f506c0a |
laanwj
added a commit
that referenced
this pull request
Mar 6, 2018
f506c0a [qt] send: Clear All also resets coin control options (Sjors Provoost) Pull request description: This change makes it so that a custom change address and manual input selection are removed if the user clicks Clear All in the send screen. Tree-SHA512: 78746043a74c9c26ef476eb0df7ce95411683749d9f6b2747222eaac751e241ea7d4d7ce9e4e69ed0b19fa76754d8584e5bef5bba1ad6598f8e39c784b4264d2
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jul 13, 2018
Github-Pull: bitcoin#12432 Rebased-From: f506c0a
HashUnlimited
pushed a commit
to chaincoin/chaincoin
that referenced
this pull request
Jan 11, 2019
Github-Pull: bitcoin#12432 Rebased-From: f506c0a
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 27, 2019
Summary: This change makes it so that a custom change address and manual input selection are removed if the user clicks Clear All in the send screen. Backport of Bitcoin Core PR12432 bitcoin/bitcoin#12432 Test Plan: 1. Start BitcoinABC wallet: `./src/qt/bitcoin-qt -regtest` 2. Enable the check named `Enable coin control features`, at Settings -> Options -> Wallet. 3. Go to Send dialog. 4. Enable the check `Custom change address` and fill with one address at the right. 5. Click on `Clear all` button. 6. Verify that the checkbox and the `Custom change address` text are cleaned. Reviewers: Fabien, #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D4078
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Apr 16, 2020
…tions f506c0a [qt] send: Clear All also resets coin control options (Sjors Provoost) Pull request description: This change makes it so that a custom change address and manual input selection are removed if the user clicks Clear All in the send screen. Tree-SHA512: 78746043a74c9c26ef476eb0df7ce95411683749d9f6b2747222eaac751e241ea7d4d7ce9e4e69ed0b19fa76754d8584e5bef5bba1ad6598f8e39c784b4264d2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that a custom change address and manual input selection are removed if the user clicks Clear All in the send screen.